copy: add fast copy path for darwin #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <[email protected]>
|
Should you have an |
|
It already exists for linux/windows. We don't have any way to test others anyway. |
tiborvass
reviewed
Apr 3, 2019
| @@ -52,6 +52,21 @@ func (c *copier) copyFileInfo(fi os.FileInfo, name string) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func copyFile(source, target string) error { | |||
There was a problem hiding this comment.
you could call this copyFileNaive in copy.go and call it as a fallback from darwin.
There was a problem hiding this comment.
But this function is not naive in linux. It does copy_file_range on linux.
tiborvass
approved these changes
Apr 3, 2019
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
Oct 24, 2019
full diff: tonistiigi/fsutil@3bbb99c...3d2716d - tonistiigi/fsutil#66 copy: add fast copy path for darwin - tonistiigi/fsutil#67 Treat Unix sockets as regular files Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
Jan 13, 2020
full diff: tonistiigi/fsutil@3bbb99c...0f039a0 - tonistiigi/fsutil#66 copy: add fast copy path for darwin - tonistiigi/fsutil#67 Treat Unix sockets as regular files - relates to moby/buildkit#1144 Fix socket handling - tonistiigi/fsutil#68 fix gocrypto commit - tonistiigi/fsutil#69 receive: use filter on receive diff - prevents incremental transfers with userns because the metadata on disk is always different than the one being transferred. Signed-off-by: Sebastiaan van Stijn <[email protected]>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Jan 13, 2020
full diff: tonistiigi/fsutil@3bbb99c...0f039a0 - tonistiigi/fsutil#66 copy: add fast copy path for darwin - tonistiigi/fsutil#67 Treat Unix sockets as regular files - relates to moby/buildkit#1144 Fix socket handling - tonistiigi/fsutil#68 fix gocrypto commit - tonistiigi/fsutil#69 receive: use filter on receive diff - prevents incremental transfers with userns because the metadata on disk is always different than the one being transferred. Signed-off-by: Sebastiaan van Stijn <[email protected]> Upstream-commit: 94a8c8b3c09540497f6fb7a3d40de80610c920ac Component: engine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tonis Tiigi [email protected]