Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split up utility targets from main dockerfile #103

Merged
merged 5 commits into from
Jul 11, 2023
Merged

split up utility targets from main dockerfile #103

merged 5 commits into from
Jul 11, 2023

Conversation

tonistiigi
Copy link
Owner

We can not use bake with linked targets to split
up ld, sdk-extras and llvm in own subdirectories.

fixes #58

Signed-off-by: Tonis Tiigi [email protected]

@tonistiigi tonistiigi force-pushed the base-split branch 6 times, most recently from 46e79b8 to 5baf701 Compare February 13, 2023 06:22
crazy-max
crazy-max reviewed Feb 13, 2023
View reviewed changes
.github/workflows/ld.yml Outdated Show resolved Hide resolved
crazy-max
crazy-max reviewed Feb 13, 2023
View reviewed changes
.github/workflows/ld.yml Outdated Show resolved Hide resolved
@tonistiigi
Copy link
Owner Author

@crazy-max Note that any PR we merge causes conflict in here.

@crazy-max
Copy link
Collaborator

Ah right sorry forgot about this one 😰

@crazy-max crazy-max force-pushed the base-split branch 3 times, most recently from 72d0da8 to 6395cc4 Compare July 11, 2023 00:36
@crazy-max
Copy link
Collaborator

@tonistiigi Rebased and added extra commits related to my comments.

@crazy-max
Copy link
Collaborator

bats-assert workflow fails but can be done in follow-up (happens for quite some time): https://github.com/tonistiigi/xx/actions/runs/5514451963/jobs/10053728550?pr=103#step:5:79

 > [build 4/6] RUN git clone --bare git://github.com/ztombol/bats-support &&     mkdir -p /out/bats-support && cd /out/bats-support &&     git --git-dir=/work/bats-support.git --work-tree=. checkout 004e707638eedd62e0481e8cdc9223ad471f12ee -- src load.bash LICENSE:
0.078 Cloning into bare repository 'bats-support.git'...
129.9 fatal: unable to connect to github.com:
129.9 github.com[0: 192.30.255.113]: errno=Operation timed out
129.9

tonistiigi and others added 5 commits July 11, 2023 03:09
@tonistiigi @crazy-max
split up utility targets from main dockerfile
bd95734 
We can not use bake with linked targets to split
up ld, sdk-extras and llvm in own subdirectories.

Signed-off-by: Tonis Tiigi <[email protected]>
@crazy-max
ci(bats-assert): align actions versions and push events
5b01cf8 
Signed-off-by: CrazyMax <[email protected]>
@crazy-max
ci: align workflows layout
3b58ae7 
Signed-off-by: CrazyMax <[email protected]>
@crazy-max
ci(ld): dynamic targets matrix
37b2adc 
Signed-off-by: CrazyMax <[email protected]>
@crazy-max
ci(ld): export cache to gha
cf86c5b 
Signed-off-by: CrazyMax <[email protected]>
@crazy-max crazy-max merged commit bb1ced0 into master Jul 11, 2023
49 of 51 checks passed
@crazy-max crazy-max mentioned this pull request Jul 13, 2023
Merged
@panekj panekj mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazy-max crazy-max crazy-max approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove base directory
2 participants
@tonistiigi @crazy-max