Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golang: fix test with pkgconf #111

Merged
merged 3 commits into from
Jul 13, 2023

Conversation

crazy-max
Copy link
Collaborator

@crazy-max crazy-max commented Jul 10, 2023

fixes #95

Since bookworm, pkgconf is installed. Before bookworm, crosswrapper scripts were created by a dpkg trigger when xx-c-essentials was installed, such as bullseye:

$ TARGETARCH=arm64 xx-apt install xx-c-essentials
...
$ ls -al /usr/bin/*pkg-config
lrwxrwxrwx 1 root root    34 Jul 10 08:57 /usr/bin/aarch64-linux-gnu-pkg-config -> /usr/share/pkg-config-crosswrapper
-rwxr-xr-x 2 root root 48000 Apr 21  2020 /usr/bin/aarch64-unknown-linux-gnu-pkg-config
-rwxr-xr-x 2 root root 48000 Apr 21  2020 /usr/bin/pkg-config
lrwxrwxrwx 1 root root    34 Jul 10 08:56 /usr/bin/x86_64-linux-gnu-pkg-config -> /usr/share/pkg-config-crosswrapper

Since bookworm this is not the case anymore:

$ TARGETARCH=arm64 xx-apt install xx-c-essentials
...
$ ls -al /usr/bin/*pkg-config
lrwxrwxrwx 1 root root 7 Jan 22 11:06 /usr/bin/pkg-config -> pkgconf
lrwxrwxrwx 1 root root 7 Jan 22 11:06 /usr/bin/x86_64-linux-gnu-pkg-config -> pkgconf

And therefore test fails.

Installing pkg config cross pkg fixes the issue:

$ TARGETARCH=arm64 xx-apt install pkg-config
...
$ ls -al /usr/bin/*pkg-config
lrwxrwxrwx 1 root root 7 Jan 22 11:06 /usr/bin/aarch64-linux-gnu-pkg-config -> pkgconf
lrwxrwxrwx 1 root root 7 Jan 22 11:06 /usr/bin/pkg-config -> pkgconf
lrwxrwxrwx 1 root root 7 Jan 22 11:06 /usr/bin/x86_64-linux-gnu-pkg-config -> pkgconf

We are inconsistent but for the sake of the tests it's fine imo.

@crazy-max
Copy link
Collaborator Author

This issue was also encountered in moby: moby/moby#45789

@thaJeztah
Copy link
Contributor

@crazy-max looks like it's failing on buster (perhaps buster should be removed from the table, as it reached EOL?)

@crazy-max
Copy link
Collaborator Author

@crazy-max looks like it's failing on buster (perhaps buster should be removed from the table, as it reached EOL?)

Yeah buster fails for quite some time now 😅

@thaJeztah
Copy link
Contributor

Hm.. different failure;

  ERROR: failed to find target base-all
  Error: The process '/usr/bin/docker' failed with exit code 1

@crazy-max
Copy link
Collaborator Author

Hm.. different failure;

  ERROR: failed to find target base-all
  Error: The process '/usr/bin/docker' failed with exit code 1

Addressed in #113

@tonistiigi tonistiigi merged commit dea0136 into tonistiigi:master Jul 13, 2023
22 of 24 checks passed
@crazy-max crazy-max deleted the fix-test-golang branch August 25, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PKG_CONFIG not set on debian bookworm
3 participants