Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bats: update git URLs #112

Merged
merged 2 commits into from
Aug 25, 2023
Merged

bats: update git URLs #112

merged 2 commits into from
Aug 25, 2023

Conversation

tonistiigi
Copy link
Owner

Github has deprecated git protocol

@thaJeztah
Copy link
Contributor

These known failures? or flaky?

#19 [test 2/2] RUN diff test.bats.output test.bats.golden
--- test.bats.output
+++ test.bats.golden
@@ -3,12 +3,12 @@
 # (from function `assert_equal' in file bats-assert/src/assert.bash, line 91,
 #  in test file test.bats, line 6)
 #   `assert_equal "foo" "bar"' failed
-#
+# 
 # -- values do not equal --
 # expected : bar
 # actual   : foo
 # --
-#
+# 
 not ok 2 run-no-success
 # (in test file test.bats, line 10)
 #   `run echo "start" && false' failed
@@ -18,14 +18,9 @@
 # (from function `assert_output' in file bats-assert/src/assert.bash, line 239,
 #  in test file test.bats, line 28)
 #   `assert_output "bcd"' failed
-#
+# 
 # -- output differs --
 # expected : bcd
 # actual   : abc
 # --
-#
-
-The following warnings were encountered during tests:
-BW01: `run`'s command `./foobar` exited with code 127, indicating 'Command not found'. Use run's return code checks, e.g. `run -127`, to fix this message.
-      (from function `run' in file /usr/lib/bats-core/test_functions.bash, line 297,
-       in test file test.bats, line 15)
+# 
 process "/bin/sh -c diff test.bats.output test.bats.golden" did not complete successfully: exit code: 1

Copy link
Contributor

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tonistiigi and others added 2 commits August 16, 2023 10:08
Github has deprecated git protocol

Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
@crazy-max crazy-max merged commit 97118f5 into master Aug 25, 2023
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants