Enforce unique, sequential ID for pet names #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves tonybaloney#161. Nota Bene: Both cat and dog names lists were missing ID 104, from 8ed7cb9.
tonybaloney
approved these changes
Oct 19, 2022
tonybaloney
added a commit
that referenced
this pull request
Feb 26, 2023
Enforce unique, sequential ID for pet names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #161.
Nota Bene
Both cat and dog names lists were missing ID 104, from 8ed7cb9.
vscode-pets/src/common/names.ts
Lines 106 to 107 in 2a1e61a
vscode-pets/src/common/names.ts
Lines 227 to 228 in 2a1e61a