Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add step to run lint before raising a PR #334

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/source/contributing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -57,3 +57,9 @@ Testing the changes
- Run `npm run compile`.
- Go to the debug panel on the sidebar and launch the development version with the extension loaded (first option in the debug profiles).
- Refer to `VS Code Extension Documentation <https://code.visualstudio.com/api>`_ for additional resources.

Submitting a PR
+++++++++++++++

- Please make sure to run `npm run lint` and verify there are no errors/warnings.
- You can run `npm run lint:fix` to fix the lint issues.