libefi: efi_get_devname: don't allocate procfs path

Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Matthew Ahrens <[email protected]> Reviewed-by: John Kennedy <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#12048
tonyhutter · Nov 12, 2021 · 73fcaed · 73fcaed
1 parent 32b9e7e
commit 73fcaed
Showing 1 changed file with 3 additions and 10 deletions.
diff --git a/lib/libefi/rdwr_efi.c b/lib/libefi/rdwr_efi.c
@@ -218,22 +218,15 @@ read_disk_info(int fd, diskaddr_t *capacity, uint_t *lbsize)
 static char *
 efi_get_devname(int fd)
 {
-	char *path;
-	char *dev_name;
-
-	path = calloc(1, PATH_MAX);
-	if (path == NULL)
-		return (NULL);
+	char path[32];
 
 	/*
 	 * The libefi API only provides the open fd and not the file path.
 	 * To handle this realpath(3) is used to resolve the block device
 	 * name from /proc/self/fd/<fd>.
 	 */
-	(void) sprintf(path, "/proc/self/fd/%d", fd);
-	dev_name = realpath(path, NULL);
-	free(path);
-	return (dev_name);
+	(void) snprintf(path, sizeof (path), "/proc/self/fd/%d", fd);
+	return (realpath(path, NULL));
 }
 
 static int