Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change strategy to to check for updates without a page reload #3

Merged
merged 2 commits into from
Nov 28, 2018

Conversation

NullVoxPopuli
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli commented Oct 6, 2018

This adds a dependency on ember-concurrency.
This polling strategy should give a more natural update feel.

Much code taken from: https://medium.com/@jonpitch/adding-a-new-build-notification-to-an-ember-application-c657211289f6

Resolves: #2
Blocked By: DockYard/ember-service-worker#130

This was referenced Oct 6, 2018
@NullVoxPopuli NullVoxPopuli changed the title change strategy to to check for updates without a page reload WIP: change strategy to to check for updates without a page reload Oct 6, 2018
@topaxi
Copy link
Owner

topaxi commented Oct 12, 2018

Awesome thanks! I'll merge this once the blocking PR is merged too. 👍

@NullVoxPopuli
Copy link
Collaborator Author

I'm super stuck on the blocking PR -- so if you want to take a look at it, that'd be a huge help. :)

@NullVoxPopuli NullVoxPopuli changed the title WIP: change strategy to to check for updates without a page reload change strategy to to check for updates without a page reload Nov 25, 2018
@NullVoxPopuli
Copy link
Collaborator Author

the blocking PR is merged, but ember-service-worker hasn't had a new release

@NullVoxPopuli
Copy link
Collaborator Author

I'm now using this at https://emberclear.io

works great!

@topaxi
Copy link
Owner

topaxi commented Nov 27, 2018

Does that mean this is save to merge but not save to publish?

@NullVoxPopuli
Copy link
Collaborator Author

@topaxi yeah. we really need @DockYard / @eshtadc to publish ember-service-worker

@eshtadc
Copy link

eshtadc commented Nov 28, 2018

Hi there - I published ember-service-worker 0.7.1 more than a week ago. I see it listed in the releases, but for some reason not in the commit history (looking into that). You can see it on npm registry as well. https://www.npmjs.com/package/ember-service-worker

@topaxi topaxi merged commit eb119e7 into topaxi:master Nov 28, 2018
@NullVoxPopuli
Copy link
Collaborator Author

thanks @eshtadc !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants