chore: Remove unnecessary method calling

lib/gruff/area.rb

@@ -30,7 +30,7 @@ def initialize_attributes
   end
 
   def draw_graph
-    x_increment = @graph_width / (column_count - 1).to_f
+    x_increment = @graph_width / (column_count - 1)
 
     store.norm_data.each do |data_row|
       poly_points = []

lib/gruff/bar.rb

@@ -103,7 +103,7 @@ def draw_graph
     # Columns sit side-by-side.
     @bar_spacing ||= @spacing_factor # space between the bars
 
-    bar_width = (@graph_width - calculate_spacing) / (column_count * store.length).to_f
+    bar_width = (@graph_width - calculate_spacing) / (column_count * store.length)
     padding = (bar_width * (1 - @bar_spacing)) / 2
 
     # Setup the BarConversion Object

lib/gruff/base.rb

@@ -422,7 +422,7 @@ def data(name, data_points = [], color = nil)
     #
     # Set it after you have given all your data to the graph object.
     def minimum_value
-      @minimum_value || store.min
+      (@minimum_value || store.min).to_f
     end
     attr_writer :minimum_value
 
@@ -432,7 +432,7 @@ def minimum_value
     # If you use this, you must set it after you have given all your data to
     # the graph object.
     def maximum_value
-      @maximum_value || store.max
+      (@maximum_value || store.max).to_f
     end
     attr_writer :maximum_value
 
@@ -505,8 +505,8 @@ def draw
     # Perform data manipulation before calculating chart measurements
     def setup_data # :nodoc:
       if @y_axis_increment && !@hide_line_markers
-        self.maximum_value = [@y_axis_increment, maximum_value, (maximum_value.to_f / @y_axis_increment).round * @y_axis_increment].max
-        self.minimum_value = [minimum_value, (minimum_value.to_f / @y_axis_increment).round * @y_axis_increment].min
+        self.maximum_value = [@y_axis_increment, maximum_value, (maximum_value / @y_axis_increment).round * @y_axis_increment].max
+        self.minimum_value = [minimum_value, (minimum_value / @y_axis_increment).round * @y_axis_increment].min
       end
     end
 
@@ -545,7 +545,7 @@ def marker_count
       @marker_count ||= begin
         count = nil
         (3..7).each do |lines|
-          if @spread.to_f % lines == 0.0
+          if @spread % lines == 0.0
             count = lines and break
           end
         end
@@ -559,7 +559,7 @@ def normalize
     end
 
     def calculate_spread
-      @spread = maximum_value.to_f - minimum_value.to_f
+      @spread = maximum_value - minimum_value
       @spread = @spread > 0 ? @spread : 1
     end
 
@@ -616,11 +616,11 @@ def draw_axis_labels
     def draw_line_markers
       return if @hide_line_markers
 
-      increment_scaled = @graph_height.to_f / (@spread / @increment)
+      increment_scaled = @graph_height / (@spread / @increment)
 
       # Draw horizontal line markers and annotate with numbers
       (0..marker_count).each do |index|
-        y = @graph_top + @graph_height - (index.to_f * increment_scaled)
+        y = @graph_top + @graph_height - (index * increment_scaled)
 
         line_renderer = Gruff::Renderer::Line.new(renderer, color: @marker_color, shadow_color: @marker_shadow_color)
         line_renderer.render(@graph_left, y, @graph_right, y)
@@ -849,7 +849,7 @@ def setup_left_margin
         if @has_left_labels
           @labels.values.reduce('') { |value, memo| value.to_s.length > memo.to_s.length ? value : memo }
         else
-          y_axis_label(maximum_value.to_f, @increment)
+          y_axis_label(maximum_value, @increment)
         end
       end
       longest_left_label_width = calculate_width(@marker_font, truncate_label_text(text))
@@ -907,7 +907,7 @@ def label(value, increment)
           else
             value.to_s
           end
-        elsif (@spread.to_f % (marker_count.to_f == 0 ? 1 : marker_count.to_f) == 0) || !@y_axis_increment.nil?
+        elsif (@spread % (marker_count == 0 ? 1 : marker_count) == 0) || !@y_axis_increment.nil?
           value.to_i.to_s
         elsif @spread > 10.0
           sprintf('%0i', value)

lib/gruff/bezier.rb

@@ -22,7 +22,7 @@ class Gruff::Bezier < Gruff::Base
 private
 
   def draw_graph
-    x_increment = @graph_width / (column_count - 1).to_f
+    x_increment = @graph_width / (column_count - 1)
 
     store.norm_data.each do |data_row|
       poly_points = []

lib/gruff/dot.rb

@@ -26,7 +26,7 @@ def draw_graph
     #
     spacing_factor = 1.0
 
-    items_width = @graph_height / column_count.to_f
+    items_width = @graph_height / column_count
     item_width = items_width * spacing_factor / store.length
     padding = (items_width * (1 - spacing_factor)) / 2
 

lib/gruff/line.rb

@@ -227,12 +227,12 @@ def draw_graph
 
   def setup_data
     # Update the global min/max values for the x data
-    @maximum_x_value ||= store.max_x
-    @minimum_x_value ||= store.min_x
+    @maximum_x_value = (@maximum_x_value || store.max_x).to_f
+    @minimum_x_value = (@minimum_x_value || store.min_x).to_f
 
     # Deal with horizontal reference line values that exceed the existing minimum & maximum values.
-    possible_maximums = [maximum_value.to_f]
-    possible_minimums = [minimum_value.to_f]
+    possible_maximums = [maximum_value]
+    possible_minimums = [minimum_value]
 
     @reference_lines.each_value do |curr_reference_line|
       if curr_reference_line.key?(:value)
@@ -255,14 +255,14 @@ def setup_drawing
   def normalize
     return unless data_given?
 
-    spread_x = @maximum_x_value.to_f - @minimum_x_value.to_f
+    spread_x = @maximum_x_value - @minimum_x_value
     store.normalize(minimum_x: @minimum_x_value, spread_x: spread_x, minimum_y: minimum_value, spread_y: @spread)
 
     @reference_lines.each_value do |curr_reference_line|
       # We only care about horizontal markers ... for normalization.
       # Vertical markers won't have a :value, they will have an :index
 
-      curr_reference_line[:norm_value] = ((curr_reference_line[:value].to_f - minimum_value) / @spread.to_f) if curr_reference_line.key?(:value)
+      curr_reference_line[:norm_value] = ((curr_reference_line[:value].to_f - minimum_value) / @spread) if curr_reference_line.key?(:value)
     end
   end
 

lib/gruff/scatter.rb

@@ -116,7 +116,7 @@ def initialize_attributes
 
   def draw_graph
     # Check to see if more than one datapoint was given. NaN can result otherwise.
-    @x_increment = @x_spread > 1 ? (@graph_width / (@x_spread - 1).to_f) : @graph_width
+    @x_increment = @x_spread > 1 ? @graph_width / (@x_spread - 1) : @graph_width
 
     store.norm_data.each do |data_row|
       data_row.coordinates.each do |x_value, y_value|
@@ -135,8 +135,8 @@ def draw_graph
 
   def setup_data
     # Update the global min/max values for the x data
-    @maximum_x_value ||= store.max_x
-    @minimum_x_value ||= store.min_x
+    @maximum_x_value = (@maximum_x_value || store.max_x).to_f
+    @minimum_x_value = (@minimum_x_value || store.min_x).to_f
 
     super
   end
@@ -190,13 +190,13 @@ def draw_line_markers
       @marker_x_count = (@x_spread / @x_axis_increment).to_i
       @x_increment = @x_axis_increment
     end
-    increment_x_scaled = @graph_width.to_f / (@x_spread / @x_increment)
+    increment_x_scaled = @graph_width / (@x_spread / @x_increment)
 
     # Draw vertical line markers and annotate with numbers
     (0..@marker_x_count).each do |index|
       # TODO: Fix the vertical lines, and enable them by default. Not pretty when they don't match up with top y-axis line
       if @show_vertical_markers
-        x = @graph_left + @graph_width - (index.to_f * increment_x_scaled)
+        x = @graph_left + @graph_width - (index * increment_x_scaled)
 
         line_renderer = Gruff::Renderer::Line.new(renderer, color: @marker_color, shadow_color: @marker_shadow_color)
         line_renderer.render(x, @graph_top, x, @graph_bottom)
@@ -205,7 +205,7 @@ def draw_line_markers
       unless @hide_line_numbers
         marker_label = (BigDecimal(index.to_s) * BigDecimal(@x_increment.to_s)) + BigDecimal(@minimum_x_value.to_s)
         y_offset = @graph_bottom + (@x_label_margin || LABEL_MARGIN)
-        x_offset = get_x_coord(index.to_f, increment_x_scaled, @graph_left)
+        x_offset = get_x_coord(index, increment_x_scaled, @graph_left)
 
         label = x_axis_label(marker_label, @x_increment)
         rotation = -90.0 if @use_vertical_x_labels

lib/gruff/side_bar.rb

@@ -99,7 +99,7 @@ def setup_graph_measurements
   def draw_graph
     # Setup spacing.
     #
-    bars_width = (@graph_height - calculate_spacing) / column_count.to_f
+    bars_width = (@graph_height - calculate_spacing) / column_count
     bar_width = bars_width / store.length
     padding = (bar_width * (1 - @bar_spacing)) / 2
 
@@ -147,7 +147,7 @@ def draw_line_markers
     number_of_lines = 1 if number_of_lines == 0
 
     # TODO: Round maximum marker value to a round number like 100, 0.1, 0.5, etc.
-    increment = significant(@spread.to_f / number_of_lines)
+    increment = significant(@spread / number_of_lines)
     (0..number_of_lines).each do |index|
       line_diff = (@graph_right - @graph_left) / number_of_lines
       x = @graph_right - (line_diff * index) - 1

lib/gruff/side_stacked_bar.rb

@@ -65,7 +65,7 @@ def draw_graph
     # Setup spacing.
     #
     # Columns sit stacked.
-    bar_width = @graph_height / column_count.to_f
+    bar_width = @graph_height / column_count
     height = Array.new(column_count, 0)
     length = Array.new(column_count, @graph_left)
     padding = (bar_width * (1 - @bar_spacing)) / 2

lib/gruff/stacked_area.rb

@@ -31,7 +31,7 @@ def setup_data
   end
 
   def draw_graph
-    x_increment = @graph_width / (column_count - 1).to_f
+    x_increment = @graph_width / (column_count - 1)
 
     height = Array.new(column_count, 0)
 

lib/gruff/stacked_bar.rb

@@ -68,7 +68,7 @@ def draw_graph
     # Setup spacing.
     #
     # Columns sit stacked.
-    bar_width = @graph_width / column_count.to_f
+    bar_width = @graph_width / column_count
     padding = (bar_width * (1 - @bar_spacing)) / 2
 
     height = Array.new(column_count, 0)