Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cypress): upgrade to [email protected] #27

Merged
merged 2 commits into from
Jun 6, 2018

Conversation

topheman
Copy link
Owner

@topheman topheman commented Jun 2, 2018

Breaking: Flag videoRecording becomes video

https://docs.cypress.io/guides/references/changelog.html#3-0-0

@topheman
Copy link
Owner Author

topheman commented Jun 2, 2018

Good enough for the upgrade.

Since the tests are done in isolation, I can't execute a script that resets the SW cache once for the whole suite (it runs for each suite):

Though, it might not still be necessary ?... cc @bahmutov

https://dashboard.cypress.io/#/projects/8r5nf4/runs/135/specs

@topheman
Copy link
Owner Author

topheman commented Jun 5, 2018

Since [email protected], each spec file runs in isolation. The tests take much longer to run compared to v2.

To speed them up, I decided to run all the files in the same spec (tests don't rely on state of previous state - they could also be ran in isolation if needed).

See implementation in 4be31f2 - I'll take a few days to figure out if I keep it or leave it.

This kind of issue has already been reported in cypress-io/cypress#1879

@topheman topheman merged commit 4f7bcbe into master Jun 6, 2018
@topheman topheman deleted the feature/upgrade-cypress@3 branch June 13, 2018 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant