Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make canvas & d3 deps optional #10

Merged
merged 1 commit into from
May 15, 2014
Merged

Make canvas & d3 deps optional #10

merged 1 commit into from
May 15, 2014

Conversation

mourner
Copy link
Contributor

@mourner mourner commented Dec 26, 2013

Canvas and D3 are only needed for png generation (while most people would use the repo for rolling out TopoJSON), and they're a trouble to install via npm if you only have command-line-tools instead of full Xcode on OS X. So I suggest moving them to optional dependencies.

If a dependency can be used, but you would like npm to proceed if it cannot be found or fails to install, then you may put it in the optionalDependencies hash. This is a map of package name to version or url, just like the dependencies hash. The difference is that failure is tolerated.

@tmcw
Copy link

tmcw commented May 15, 2014

👍 node-canvas also has some issues with homebrew which make it a bother to install sometimes.

@mbostock
Copy link
Member

Makes sense, especially now that it doesn’t make the PNG targets by default.

@mbostock mbostock merged commit 1d6b928 into topojson:master May 15, 2014
@mourner mourner deleted the patch-1 branch May 15, 2014 20:13
@mourner
Copy link
Contributor Author

mourner commented May 15, 2014

Thanks Mike!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants