Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if ip address when sanitizing urls #9

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

sebastiendan
Copy link
Member

Description

This PR fixes the URL sanitization util function so that it checks if endpoint is an ip address (and doesn't use secure connections in that case).

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@sebastiendan sebastiendan self-assigned this Sep 4, 2023
@sebastiendan sebastiendan merged commit 22f2b3d into main Sep 4, 2023
@sebastiendan sebastiendan deleted the fix/sanitize-url-ip-addresses branch September 4, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant