Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: Deprecate xsrf_cookies #3226

Closed
wants to merge 4 commits into from

Commits on Feb 1, 2023

  1. web: Deprecate xsrf_cookies (and xsrf_token, etc)

    This feature is more invasive than using the samesite cookie attribute
    but does not provide additional protection, so it is no longer
    something that we should recommend.
    
    Now that this feature is deprecated, the open issues related to it
    will not be fixed (however, I intend to keep the current code around
    indefinitely; there are no plans to remove it).
    
    Closes tornadoweb#865
    Closes tornadoweb#2573
    Closes tornadoweb#3026
    bdarnell committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    0558518 View commit details
    Browse the repository at this point in the history
  2. web: Support "name" in xsrf_cookie_kwargs

    This small new functionality in a deprecated feature may provide
    a higher level of security; if this turns out to be useful in practice
    we may un-deprecate the xsrf_cookies feature.
    bdarnell committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    1dd77a8 View commit details
    Browse the repository at this point in the history
  3. demos: lint fixes

    bdarnell committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    6c37366 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dfd205e View commit details
    Browse the repository at this point in the history