Fix for [#247] search bar not working when in /torrents endpoint #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mario-nt
deleted the
#247-search-bar-not-working-when-in-/torrents-endpoint
branch
mario-nt
restored the
#247-search-bar-not-working-when-in-/torrents-endpoint
branch
josecelano
requested changes
Sep 4, 2023
There was a problem hiding this comment.
Hi @mario-nt, It works, but we are making unnecessary requests.
The request to get the torrents is made four times.
|
Hi @mario-nt I've tested it, and it works. Tests are failing because the Tracker container image has changed, and we need to update the docker-compose configuration as I'm doing on the Index Backend. I've created a new issue: #262 I will finish that issue, then I will do the same here in this repo, and finally, we can re-run tests in this PR. If everything is OK I will merge it. |
|
I clicked on |
added 2 commits
September 12, 2023 13:51
Using the search bar in the /torrents endpoint, now actually calls the API to fetch the torrents with the search query and displays the result, making the torrents component render again with the results matching the search prompt. A key was added to the <NuxtPage> component so the watcher listening for a new search prompt gets triggered. Also, minor refactoring was applied to the code to follow good practices and clean up unused imports and variables.
…oint Code has been refactor and now looks cleaner and easier to understand.
mario-nt
force-pushed
the
#247-search-bar-not-working-when-in-/torrents-endpoint
branch
from
b900217
to
6c72733
Compare
|
Rebase and tests OK, ready to be reviewed @josecelano . |
|
ACK 6c72733 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #247
The search bar was not working when in the /torrents endpoint, because the watcher listening for changes in the url path was not triggering when the user searches for a specific torrent.