Fixes [257] unnecessary repetitive requests using the search bar #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mario-nt I think you have to rebase this PR to fix the problem with the missing Tracker service after starting the container with docker compose. Tha should fix the tests. |
|
Hi @josecelano, yes, I have to do the rebase with the develop branch before running the tests, I'll do it and let you know. |
Assigning the search query value to the variable used to fetch the searched torrents is now done through the onActivated hook, avoiding triggering the watchers, and thus, not making another unnecessary fetch request to the back-end, getting the torrents only once.
mario-nt
force-pushed
the
issue-257-unnecessary-repetitive-requests-using-the-search-bar
branch
from
dcb01d5
to
8cc222e
Compare
|
@josecelano Rebase and tests OK |
|
ACK 8cc222e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #257
Assigning the search query value to the variable used to fetch the searched torrents is now done through the onActivated hook, avoiding triggering the watchers, and thus, not making another unnecessary fetch request to the back-end, getting the torrents only once.