Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force accept agreement before uploading #623

Conversation

josecelano
Copy link
Member

@josecelano josecelano commented Sep 15, 2024

I added a new checkbox to force users to accept the terms and conditions before uploading a torrent.

@josecelano
Copy link
Member Author

josecelano commented Sep 15, 2024

image

@josecelano josecelano linked an issue Sep 15, 2024 that may be closed by this pull request
@josecelano josecelano force-pushed the 622-add-the-legal-checkbox-to-the-upload-torrent-form branch 3 times, most recently from e0e4717 to e992453 Compare September 15, 2024 11:17
@josecelano josecelano self-assigned this Sep 15, 2024
@josecelano josecelano added this to the v3.0.0 milestone Sep 15, 2024
@josecelano josecelano added Enhancement / Feature Request Something New Legal Licenses and other Official Documents - User - Enjoyable to Use our Software labels Sep 15, 2024
@josecelano
Copy link
Member Author

The link should look like:

image

To make it clear, it's a link, but the general style for links in the app is set to not use text-decoration.

@josecelano josecelano marked this pull request as ready for review September 15, 2024 11:21
@josecelano josecelano marked this pull request as draft September 15, 2024 11:22
@da2ce7
Copy link
Contributor

da2ce7 commented Sep 16, 2024

"I comprehend and agree with this index's usage and content policy and that this upload is in full compliance and that this upload is a meaningful contribution according to the sprit and goals this index."

@josecelano
Copy link
Member Author

"I comprehend and agree with this index's usage and content policy and that this upload is in full compliance and that this upload is a meaningful contribution according to the sprit and goals this index."

torrust/torrust-index#732

Copy link
Member

@cgbosse cgbosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@cgbosse
Copy link
Member

cgbosse commented Sep 16, 2024

"I comprehend and agree with this index's usage and content policy and that this upload is in full compliance and that this upload is a meaningful contribution according to the sprit and goals this index."

I think that this may be a little overkill.

I propose instead:

"I have read and agree with the Usage Policies and Content Restrictions."

@josecelano
Copy link
Member Author

"I comprehend and agree with this index's usage and content policy and that this upload is in full compliance and that this upload is a meaningful contribution according to the sprit and goals this index."

I think that this may be a little overkill.

I propose instead:

"I have read and agree with the Usage Policies and Content Restrictions."

Hi @cgbosse, I've opened a new issue because that's a change we have to make to the Index. In fact, It's only the default value. You can override it with a configuration value:

https://github.com/torrust/torrust-index/blob/develop/tests/fixtures/default_configuration.toml#L15

[website.terms.upload]
content_upload_agreement = """I confirm that the content I am uploading is authorized, and I have read and agree to the terms."""

@josecelano josecelano force-pushed the 622-add-the-legal-checkbox-to-the-upload-torrent-form branch from e992453 to a6ee38f Compare September 16, 2024 08:14
@josecelano
Copy link
Member Author

ACK a6ee38f

@josecelano josecelano marked this pull request as ready for review September 16, 2024 08:21
@josecelano josecelano merged commit 560cc89 into torrust:develop Sep 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- User - Enjoyable to Use our Software Enhancement / Feature Request Something New Legal Licenses and other Official Documents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the "legal checkbox" to the upload torrent form
3 participants