Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: the function services::torrent::Index::add_torrent #305

Merged
merged 11 commits into from
Sep 20, 2023
Merged

Refactor: the function services::torrent::Index::add_torrent #305

merged 11 commits into from
Sep 20, 2023

Conversation

josecelano
Copy link
Member

@josecelano josecelano commented Sep 19, 2023 •
edited
Loading

  • Reorganize tests in torrent context contract.
  • Add more tests before the refactoring.
  • Refactorings.

@josecelano josecelano temporarily deployed to coverage September 19, 2023 15:24 — with GitHub Actions Inactive
@josecelano josecelano changed the title Refactor: services::torrent::Index::add_torrent Refactor: the function services::torrent::Index::add_torrent Sep 19, 2023
@josecelano josecelano temporarily deployed to coverage September 19, 2023 15:24 — with GitHub Actions Inactive
@josecelano josecelano linked an issue Sep 19, 2023 that may be closed by this pull request
Refactor: services::torrent::Index::add_torrent #276
Closed
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2023 •
edited
Loading

Codecov Report

Merging #305 (a302c22) into develop (76338b1) will increase coverage by 0.36%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #305      +/-   ##
===========================================
+ Coverage    43.65%   44.01%   +0.36%     
===========================================
  Files           77       77              
  Lines         4387     4387              
===========================================
+ Hits          1915     1931      +16     
+ Misses        2472     2456      -16

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@josecelano josecelano temporarily deployed to coverage September 19, 2023 16:03 — with GitHub Actions Inactive
@josecelano josecelano temporarily deployed to coverage September 19, 2023 16:04 — with GitHub Actions Inactive
@josecelano josecelano temporarily deployed to coverage September 19, 2023 16:43 — with GitHub Actions Inactive
@josecelano josecelano temporarily deployed to coverage September 19, 2023 16:43 — with GitHub Actions Inactive
@josecelano josecelano temporarily deployed to coverage September 20, 2023 12:32 — with GitHub Actions Inactive
@josecelano josecelano temporarily deployed to coverage September 20, 2023 12:32 — with GitHub Actions Inactive
@josecelano josecelano temporarily deployed to coverage September 20, 2023 12:51 — with GitHub Actions Inactive
@josecelano josecelano temporarily deployed to coverage September 20, 2023 12:51 — with GitHub Actions Inactive
@josecelano josecelano temporarily deployed to coverage September 20, 2023 13:10 — with GitHub Actions Inactive
@josecelano josecelano temporarily deployed to coverage September 20, 2023 13:11 — with GitHub Actions Inactive
@josecelano josecelano temporarily deployed to coverage September 20, 2023 13:37 — with GitHub Actions Inactive
@josecelano josecelano temporarily deployed to coverage September 20, 2023 13:37 — with GitHub Actions Inactive
@josecelano
feat!: [#276] upload torrent returns 400 instead of empty response
4cc97c7 
when the original info-hash of the upload torrent cannot be calculated.

The API should not return empty responses, so "panic" should not be use
for common problems that we should notify to the user.
@josecelano josecelano temporarily deployed to coverage September 20, 2023 15:07 — with GitHub Actions Inactive
@josecelano josecelano temporarily deployed to coverage September 20, 2023 15:07 — with GitHub Actions Inactive
@josecelano josecelano temporarily deployed to coverage September 20, 2023 15:25 — with GitHub Actions Inactive
@josecelano josecelano temporarily deployed to coverage September 20, 2023 15:25 — with GitHub Actions Inactive
@josecelano josecelano temporarily deployed to coverage September 20, 2023 15:33 — with GitHub Actions Inactive
@josecelano josecelano temporarily deployed to coverage September 20, 2023 15:33 — with GitHub Actions Inactive
@josecelano josecelano temporarily deployed to coverage September 20, 2023 15:59 — with GitHub Actions Inactive
@josecelano josecelano temporarily deployed to coverage September 20, 2023 15:59 — with GitHub Actions Inactive
@josecelano
feat!: [#276] do not persist uploaded torrent if it cannot persit tags
fbb42ad 
When you upload a torrent the transaction wraps all the persisted data.

Before this change, if tags can't be stored in the database the rest of
the indexed data is stored anyway.
@josecelano
refactor: [#276] extract fn Torrent::import_torrent_statistics_from_t…
f19e801 
…racker
@josecelano josecelano temporarily deployed to coverage September 20, 2023 16:26 — with GitHub Actions Inactive
@josecelano josecelano temporarily deployed to coverage September 20, 2023 16:32 — with GitHub Actions Inactive
@josecelano josecelano marked this pull request as ready for review September 20, 2023 16:33
@josecelano josecelano temporarily deployed to coverage September 20, 2023 16:41 — with GitHub Actions Inactive
@josecelano josecelano temporarily deployed to coverage September 20, 2023 16:41 — with GitHub Actions Inactive
@josecelano
Copy link
Member Author

ACK 275231a

@josecelano josecelano merged commit 0d7d72f into torrust:develop Sep 20, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@da2ce7 da2ce7 Awaiting requested review from da2ce7

Assignees
No one assigned
Labels
None yet
Projects
Torrust Solution
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor: services::torrent::Index::add_torrent
2 participants
@josecelano @codecov-commenter