Improve Tracker API errors log #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need the specifix error requesting the tracker API to include the error in the logs.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #425 +/- ##
===========================================
- Coverage 42.89% 41.36% -1.53%
===========================================
Files 80 80
Lines 4933 4994 +61
===========================================
- Hits 2116 2066 -50
- Misses 2817 2928 +111 ☔ View full report in Codecov by Sentry. |
Some cases were missing when the tracker service processes the responses from the tracker API. Added debugging and error log. todo: add tests
Now you can see the exact error when the tracker API fails. For example, the following error when the torrent is not found: ``` 2024-01-03T17:25:49.817570509+00:00 [statistics_importer][ERROR] Error updating torrent tracker stats for torrent with id 3; info-hash c0bae61394917c2cc3aa3af9c2291bfe80b5bbf4. Error: TorrentNotFound ```
|
ACK ff90e9e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the specific error requesting the tracker API to include the error in the logs.