Merge #873: Implment Request Stream for UDP Tracker

84cc1a1 dev: use stream for udp requests (Cameron Garnham)

Pull request description:

  This pull request improves the UDP tracker `server.rs` request processing logic; now using a `tokio::stream` for getting the requests for the ring buffer.

  I hope this pull request will improve the performance of the tracker in multi-core setups.

  @josecelano This code will require a special code-review.

ACKs for top commit:
  josecelano:
    ACK 84cc1a1

Tree-SHA512: 84d33426583c12b0f39bd0c3a6c48f9a510fdfbbf36da000307e809bce4f7870a53b840eda326492d29f21b83611cdc610b03ec30aa675179635ac6ea19ddd34

.cargo/config.toml

@@ -23,4 +23,3 @@ rustflags = [
     "-D",
     "unused",
 ]
-

cSpell.json

@@ -34,10 +34,12 @@
         "codecov",
         "codegen",
         "completei",
+        "Condvar",
         "connectionless",
         "Containerfile",
         "conv",
         "curr",
+        "cvar",
         "Cyberneering",
         "dashmap",
         "datagram",

src/lib.rs

@@ -494,7 +494,7 @@ pub mod bootstrap;
 pub mod console;
 pub mod core;
 pub mod servers;
-pub mod shared;
+pub mod shared; 
 
 #[macro_use]
 extern crate lazy_static;

src/servers/udp/handlers.rs

@@ -10,7 +10,6 @@ use aquatic_udp_protocol::{
     ErrorResponse, Ipv4AddrBytes, Ipv6AddrBytes, NumberOfDownloads, NumberOfPeers, Port, Request, Response, ResponsePeer,
     ScrapeRequest, ScrapeResponse, TorrentScrapeStatistics, TransactionId,
 };
-use tokio::net::UdpSocket;
 use torrust_tracker_located_error::DynError;
 use torrust_tracker_primitives::info_hash::InfoHash;
 use tracing::debug;
@@ -34,13 +33,12 @@ use crate::shared::bit_torrent::common::MAX_SCRAPE_TORRENTS;
 /// - Delegating the request to the correct handler depending on the request type.
 ///
 /// It will return an `Error` response if the request is invalid.
-pub(crate) async fn handle_packet(udp_request: UdpRequest, tracker: &Arc<Tracker>, socket: Arc<UdpSocket>) -> Response {
+pub(crate) async fn handle_packet(udp_request: UdpRequest, tracker: &Arc<Tracker>, addr: SocketAddr) -> Response {
     debug!("Handling Packets: {udp_request:?}");
 
     let start_time = Instant::now();
 
     let request_id = RequestId::make(&udp_request);
-    let server_socket_addr = socket.local_addr().expect("Could not get local_addr for socket.");
 
     match Request::parse_bytes(&udp_request.payload[..udp_request.payload.len()], MAX_SCRAPE_TORRENTS).map_err(|e| {
         Error::InternalServer {
@@ -49,7 +47,7 @@ pub(crate) async fn handle_packet(udp_request: UdpRequest, tracker: &Arc<Tracker
         }
     }) {
         Ok(request) => {
-            log_request(&request, &request_id, &server_socket_addr);
+            log_request(&request, &request_id, &addr);
 
             let transaction_id = match &request {
                 Request::Connect(connect_request) => connect_request.transaction_id,
@@ -64,7 +62,7 @@ pub(crate) async fn handle_packet(udp_request: UdpRequest, tracker: &Arc<Tracker
 
             let latency = start_time.elapsed();
 
-            log_response(&response, &transaction_id, &request_id, &server_socket_addr, latency);
+            log_response(&response, &transaction_id, &request_id, &addr, latency);
 
             response
         }