Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: the tracker checker result for UDP tracker shows "Announce" for the Scrape test. #1037

Closed
josecelano opened this issue Sep 11, 2024 · 0 comments · Fixed by #1038
Closed

Bug: the tracker checker result for UDP tracker shows "Announce" for the Scrape test. #1037

josecelano opened this issue Sep 11, 2024 · 0 comments · Fixed by #1038
Assignees
@josecelano
Labels
- Developer - Torrust Improvement Experience Bug Incorrect Behavior
Milestone
v3.0.0

Comments

@josecelano
Copy link
Member

Relates to: #682

This is the output when the "scrape" requests timeout.

$ TORRUST_CHECKER_CONFIG='{
    "udp_trackers": ["127.0.0.1:6969"],
    "http_trackers": [],
    "health_checks": []
}' cargo run --bin tracker_checker
   Compiling torrust-tracker v3.0.0-rc.1-develop (/home/josecelano/Documents/git/committer/me/github/torrust/torrust-tracker)
    Finished `dev` profile [optimized + debuginfo] target(s) in 14.73s
     Running `target/debug/tracker_checker`
2024-09-11T08:31:26.362237Z  INFO torrust_tracker::console::clients::checker::service: Running checks for trackers ...
[
  {
    "Udp": {
      "Err": {
        "remote_addr": "127.0.0.1:6969",
        "results": [
          [
            "Setup",
            {
              "Ok": null
            }
          ],
          [
            "Connect",
            {
              "Ok": null
            }
          ],
          [
            "Announce",
            {
              "Ok": null
            }
          ],
          [
            "Announce",
            {
              "Err": "Failed to receive a scrape response, with error: Timeout while trying to receive data."
            }
          ]
        ]
      }
    }
  }
]
@josecelano josecelano added Bug Incorrect Behavior - Developer - Torrust Improvement Experience labels Sep 11, 2024
@josecelano josecelano added this to the v3.0.0 milestone Sep 11, 2024
@josecelano josecelano self-assigned this Sep 11, 2024
@josecelano josecelano mentioned this issue Sep 11, 2024
Closed
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Sep 11, 2024
@josecelano
fix: [torrust#1037] wrong req type name in tracker checker outout
dbee825 
Fixed ouoput:

```output
$ TORRUST_CHECKER_CONFIG='{
    "udp_trackers": ["127.0.0.1:6969"],
    "http_trackers": [],
    "health_checks": []
}' cargo run --bin tracker_checker
   Compiling torrust-tracker v3.0.0-rc.1-develop (/home/josecelano/Documents/git/committer/me/github/torrust/torrust-tracker)
    Finished `dev` profile [optimized + debuginfo] target(s) in 15.42s
     Running `target/debug/tracker_checker`
2024-09-11T09:44:57.432395Z  INFO torrust_tracker::console::clients::checker::service: Running checks for trackers ...
[
  {
    "Udp": {
      "Ok": {
        "remote_addr": "127.0.0.1:6969",
        "results": [
          [
            "Setup",
            {
              "Ok": null
            }
          ],
          [
            "Connect",
            {
              "Ok": null
            }
          ],
          [
            "Announce",
            {
              "Ok": null
            }
          ],
          [
            "Scrape",
            {
              "Ok": null
            }
          ]
        ]
      }
    }
  }
]
```
@josecelano josecelano linked a pull request Sep 11, 2024 that will close this issue
Fix: wrong req type name in tracker checker output #1038
Merged
josecelano added a commit that referenced this issue Sep 11, 2024
@josecelano
Merge #1038: Fix: wrong req type name in tracker checker output
befbe1b 
dbee825 fix: [#1037] wrong req type name in tracker checker outout (Jose Celano)

Pull request description:

  Fix wrong req type name in tracker checker output.

  Command:

  ```console
  $ TORRUST_CHECKER_CONFIG='{
      "udp_trackers": ["127.0.0.1:6969"],
      "http_trackers": [],
      "health_checks": []
  }' cargo run --bin tracker_checker
  ```

  ```output
     Compiling torrust-tracker v3.0.0-rc.1-develop (/home/josecelano/Documents/git/committer/me/github/torrust/torrust-tracker)
      Finished `dev` profile [optimized + debuginfo] target(s) in 15.42s
       Running `target/debug/tracker_checker`
  2024-09-11T09:44:57.432395Z  INFO torrust_tracker::console::clients::checker::service: Running checks for trackers ...
  ```

  Fixed output:

  ```json
  [
    {
      "Udp": {
        "Ok": {
          "remote_addr": "127.0.0.1:6969",
          "results": [
            [
              "Setup",
              {
                "Ok": null
              }
            ],
            [
              "Connect",
              {
                "Ok": null
              }
            ],
            [
              "Announce",
              {
                "Ok": null
              }
            ],
            [
              "Scrape",
              {
                "Ok": null
              }
            ]
          ]
        }
      }
    }
  ]
  ```

  The previous output was:

  ```json
  [
    {
      "Udp": {
        "Ok": {
          "remote_addr": "127.0.0.1:6969",
          "results": [
            [
              "Setup",
              {
                "Ok": null
              }
            ],
            [
              "Connect",
              {
                "Ok": null
              }
            ],
            [
              "Announce",
              {
                "Ok": null
              }
            ],
            [
              "Announce",
              {
                "Ok": null
              }
            ]
          ]
        }
      }
    }
  ]
  ```

ACKs for top commit:
  josecelano:
    ACK dbee825

Tree-SHA512: fc4d8f1317052e5d4061eb69b5104f281ee39d1a4381ad30c5ea7b7fa88618059d1533c40c1a9182a382a80f73bdea2841b357bbfc12fa18349181d3fd3ca0db
josecelano added a commit that referenced this issue Sep 23, 2024
@josecelano
Merge #1045: Release Version 3.0.0-rc.1
569b222 
beb56d3 release: version 3.0.0-rc.1 (Jose Celano)
bdb0419 chore(deps): update dependencies (Jose Celano)
faee02f feat: [#675] tracker checker (HTTP tracker) supports more service address formats (Jose Celano)
520026d feat: [#675] tracker checker supports more service address formats (Jose Celano)
dbee825 fix: [#1037] wrong req type name in tracker checker outout (Jose Celano)
c49438f fix: remove debugging print (Jose Celano)
084879e feat: [#569] numwant HTTP tracker announce param (Jose Celano)
481d413 feat: [#569] allow UDP clients to limit peers in response (Jose Celano)
ff836ed fix: clippy error (Jose Celano)
1f64cc9 chore(deps): udpate dependencies (Jose Celano)
b88cc61 develop: bump to version 3.0.0-rc.1-develop (Jose Celano)

Pull request description:

  Release Version 3.0.0-rc.1

ACKs for top commit:
  josecelano:
    ACK beb56d3

Tree-SHA512: fb923cb93948123fe4af4f144aaedd72f33aabde1428aac5f14d15eec3b0779b0663c6b1e2580e32c920e343529d1bdbd472b4a1f58592126bb12188bfe4ae7a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josecelano josecelano

Labels
- Developer - Torrust Improvement Experience Bug Incorrect Behavior
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

Fix: wrong req type name in tracker checker output josecelano/torrust-tracker
1 participant
@josecelano