Refactor: split global consts for limits #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josecelano
force-pushed
the
issue-262-refactor-global-constants
branch
from
7b82050
to
db6258b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #568 +/- ##
===========================================
- Coverage 79.31% 79.30% -0.02%
===========================================
Files 117 117
Lines 7785 7736 -49
===========================================
- Hits 6175 6135 -40
+ Misses 1610 1601 -9 ☔ View full report in Codecov by Sentry. |
Current const: `crate::shared::bit_torrent::common::MAX_SCRAPE_TORRENTS` `MAX_SCRAPE_TORRENTS` is the limit only for the number of torrents in a `scrape`request. New const: `crate::core::TORRENT_PEERS_LIMIT` `TORRENT_PEERS_LIMIT` is now the limit for the number of peers in an announce request (UDP and HTTP tracker). Besides, the endpoint to get the torrent details in the API does not limit the number of peers for the torrent. So the API returns all peers in the tracker. This could lead to performance issues and we might need to paginate results, but the API should either return all peers and paginate them in a new endpoint.
josecelano
force-pushed
the
issue-262-refactor-global-constants
branch
from
db6258b
to
46e67a8
Compare
|
ACK 46e67a8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current const:
crate::shared::bit_torrent::common::MAX_SCRAPE_TORRENTSMAX_SCRAPE_TORRENTSis the limit only for the number of torrents in ascraperequest.New const:
crate::core::TORRENT_PEERS_LIMITTORRENT_PEERS_LIMITis now the limit for the number of peers in an announce request (UDP and HTTP tracker).Besides, the endpoint to get the torrent details in the API does not limit the number of peers for the torrent. So the API returns all peers in the tracker. This could lead to performance issues and we might need to paginate results, but the API should either return all peers and paginate them in a new endpoint.