Extract Config from Tracker and Heath Check #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #623 +/- ##
===========================================
+ Coverage 77.16% 77.62% +0.45%
===========================================
Files 124 125 +1
Lines 8242 8334 +92
===========================================
+ Hits 6360 6469 +109
+ Misses 1882 1865 -17 ☔ View full report in Codecov by Sentry. |
josecelano
previously approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Wonderful job @da2ce7! I've only added some comments for things that were "harder" to read for me. I mean, I had to read the details to understand what they do, but only in a few cases and it was fast to get on track. So it's perfectly mergeable.
da2ce7
force-pushed
the
20240117_cleanup_health_check
branch
from
f073af8
to
fda6f41
Compare
da2ce7
force-pushed
the
20240117_cleanup_health_check
branch
from
fda6f41
to
3f0dcea
Compare
|
ACK 3f0dcea |
|
Hi @da2ce7 after merging this PR there are some new problems running the services. I want to add E2E tests to avoid this type of regression. |
josecelano
added a commit
that referenced
this pull request
Jan 19, 2024
17296cd fix: [#626] healt check api server shutdown (Jose Celano) bbf1be6 fix: don't start HTTP tracker if it's disabled (Jose Celano) Pull request description: This fixes all errors introduced after merging [this PR](#623). - [x] HTTP tracker should not be started if it's disabled Error running the Health Check API server: ```console thread 'tokio-runtime-worker' panicked at src/servers/signals.rs:52:25: Failed to install stop signal: channel closed ``` ACKs for top commit: josecelano: ACK 17296cd Tree-SHA512: 95fb8011f6eb58b52f8805185ccabb484be29d6231930aaa9a24d4a9b0a4b5dd457259a343c4a337529264ecd42f76609a57914a661a7ce19255e0fcb41a3145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first three commits from #557
It includes an significant improvement of the Heath Check logic, as it now takes the active port from the binding, instead of the configuration.