-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timeouts for Axum server in the Tracker API #865
Merged
josecelano
merged 3 commits into
torrust:develop
from
josecelano:612-tracker-api-add-a-timeout-to-the-tls-handshake-waiting-for-headers-and-waiting-for-receiving-headers
May 15, 2024
Merged
Add timeouts for Axum server in the Tracker API #865
josecelano
merged 3 commits into
torrust:develop
from
josecelano:612-tracker-api-add-a-timeout-to-the-tls-handshake-waiting-for-headers-and-waiting-for-receiving-headers
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to add timeouts for the Axum server configuration, in order to close HTTP connections when the client doesn't send any request after opening a HTTP connection.
…uests Adds a timeout for the Tracker API for the time the server waits for the first request from the client after openning a new HTTP connection.
josecelano
added
Security
Publicly Connected to Security
- Admin -
Enjoyable to Install and Setup our Software
labels
May 15, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #865 +/- ##
===========================================
+ Coverage 78.74% 78.82% +0.08%
===========================================
Files 169 170 +1
Lines 9300 9398 +98
===========================================
+ Hits 7323 7408 +85
- Misses 1977 1990 +13 ☔ View full report in Codecov by Sentry. |
josecelano
force-pushed
the
612-tracker-api-add-a-timeout-to-the-tls-handshake-waiting-for-headers-and-waiting-for-receiving-headers
branch
from
May 15, 2024 11:52
82c9792
to
9e42a1a
Compare
ACK 9e42a1a |
This was referenced May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add timeouts for Axum server in the Tracker API:
http2_keep_alive_interval
is disabled.The current implementation for the first timeout does not send any message (408 Request Timeout). It seems is also common practice.
To test the first case, you can open a connection to the API without sending any request with:
After 5 seconds you will see:
For advanced manual testing, you can use: https://github.com/josecelano/axum-server-timeout