Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config overhaul: lowercase for DatabaseDriver #953

Merged
merged 5 commits into from
Jul 5, 2024
Merged

Config overhaul: lowercase for DatabaseDriver #953

merged 5 commits into from
Jul 5, 2024

Conversation

josecelano
Copy link
Member

@josecelano josecelano commented Jul 5, 2024 •
edited
Loading

Use lowercase for database driver values in the configuration:

[core.database]
driver = "sqlite3"
#driver = "MySQL"

Instead of:

[core.database]
driver = "Sqlite3"
#driver = "MySql"

We are normalizing all enum variants in the configuration to lowercase.

It also decouples the internal database driver enum from the enum used in the configuration.

@josecelano
refactor: [torrust#950] decouple database driver enum
9be9638 
Use a different enum for configuration and domain.
@josecelano
refactor: [torrust#950] move DatabaseDriver to databases mod
954295a
@josecelano
refactor: [torrust#950] rename DatabaseDriver to Driver
d970bb8
@josecelano
feat: [torrust#950] use lowercase for database driver values in confi…
9d72f51 
…guration

```toml
[core.database]
driver = "sqlite3"
```

We are normalizing all enum variants in configration to lowercase.
@josecelano josecelano self-assigned this Jul 5, 2024
@josecelano josecelano requested a review from da2ce7 July 5, 2024 09:26
@josecelano josecelano linked an issue Jul 5, 2024 that may be closed by this pull request
Config overhaul: lowercase for DatabaseDriver #950
Closed
@josecelano josecelano added this to the v3.0.0 milestone Jul 5, 2024
@josecelano josecelano mentioned this pull request Jul 5, 2024
Closed
@josecelano
Copy link
Member Author

ACK ca348a8

@josecelano josecelano mentioned this pull request Jul 5, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 59.25926% with 11 lines in your changes missing coverage. Please review.

Project coverage is 77.31%. Comparing base (c747321) to head (ca348a8).

Files Patch % Lines
src/core/databases/error.rs 18.18% 9 Missing ⚠️
src/core/databases/driver.rs 75.00% 1 Missing ⚠️
src/core/mod.rs 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #953      +/-   ##
===========================================
- Coverage    77.31%   77.31%   -0.01%     
===========================================
  Files          183      183              
  Lines         9731     9735       +4     
===========================================
+ Hits          7524     7527       +3     
- Misses        2207     2208       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josecelano josecelano merged commit 035d630 into torrust:develop Jul 5, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@da2ce7 da2ce7 Awaiting requested review from da2ce7

Assignees

@josecelano josecelano

Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

Config overhaul: lowercase for DatabaseDriver
1 participant
@josecelano