Re-align CustomAuth #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metalurgical
force-pushed
the
features_update
branch
4 times, most recently
from
931ca9c
to
9961534
Compare
metalurgical
force-pushed
the
features_update
branch
8 times, most recently
from
2777a8f
to
473faf6
Compare
metalurgical
force-pushed
the
features_update
branch
from
473faf6
to
129926a
Compare
This PR seeks to re-align the current implementation of custom-auth-swift to that of the web implementation of CustomAuth. This will reduce the overhead of differences a developer would need to remember between the two and provide an overall better experience. This will also provide better long term maintainability and make feature parity simpler to implement between the two. Note this is a breaking change and needs to be released as a major version.
metalurgical
force-pushed
the
features_update
branch
from
129926a
to
72a83f3
Compare
himanshuchawla009
requested changes
Sep 4, 2024
Sources/CustomAuth/Common/LoginParams/TorusSubVerifierInfo.swift
Outdated
Show resolved
Hide resolved
Sources/CustomAuth/Common/VerifierResponses/TorusVerifierResponses.swift
Outdated
Show resolved
Hide resolved
Check defaults for CustomAuthArgs Check login types, implement caseSensitiveField helper function, use helper in getVerifierId
commenting it out since it will need to be put back in the passkeys implementation
|
Comments have been resolved. I think more than once review and approval on this PR is very necessary, before it can be merged. |
shahbaz17
reviewed
Sep 9, 2024
metalurgical
requested review from
himanshuchawla009,
chaitanyapotti and
shahbaz17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeks to re-align the current implementation of custom-auth-swift to that of the web implementation of CustomAuth.
This will reduce the overhead of differences a developer would need to remember between the two and provide an overall better experience.
This will also provide better long term maintainability and make feature parity simpler to implement between the two.
PassKeys and Hosted Passwordless is not part of this PR.
Note this is a breaking change and needs to be released as a major version.