Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/embed params #208

Merged
merged 7 commits into from
Mar 18, 2022
Merged

Feat/embed params #208

merged 7 commits into from
Mar 18, 2022

Conversation

ieow
Copy link
Contributor

@ieow ieow commented Mar 11, 2022

add support embed signing Transaction with Message serialized and return signatures.
support backward compatibility

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Support embed signing Transaction with Transaction.serialize.

Issue Number: N/A

What is the new behavior?

  • Support embed signing Transaction with both Transaction serialized and Message serialized

Other information

Require embed PR torusresearch/solana-embed#36 and controller PR https://github.com/torusresearch/controllers/pull/103

Copy link
Contributor

@metallicalfa2 metallicalfa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@metallicalfa2 metallicalfa2 merged commit dad64fe into develop Mar 18, 2022
@ieow ieow deleted the feat/embed_params branch March 18, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants