Merge pull request #1 from torvalds/master #355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello,world!
plbossart
pushed a commit
to plbossart/sound
that referenced
this pull request
Aug 26, 2021
Fixed following WARNINGs: for torvalds#355, removed this unnecessary log print. for torvalds#364, added a variable to "struct es8316_priv", and tried to let function es8316_enable_jack_detect() align to mainline code. for torvalds#452, removed it since we did not verified the patch on other platform. WARNING: Unnecessary ftrace-like logging - prefer using ftrace torvalds#355: FILE: sound/soc/codecs/es8316.c:751: + dev_dbg(comp->dev, "Exit %s\n", __func__); ERROR: do not initialise statics to 0 torvalds#364: FILE: sound/soc/codecs/es8316.c:760: + static int initial = 0; WARNING: DT compatible string "everest,es8336" appears un-documented -- check ./Documentation/devicetree/bindings/ torvalds#452: FILE: sound/soc/codecs/es8316.c:932: + { .compatible = "everest,es8336", }, Signed-off-by: Huajun Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,world!