feat: hangulIncludes 함수를 삭제합니다 #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 18c264a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2 #188 +/- ##
=====================================
Coverage ? 95.08%
=====================================
Files ? 15
Lines ? 285
Branches ? 67
=====================================
Hits ? 271
Misses ? 13
Partials ? 1 |
manudeli
approved these changes
Jul 14, 2024
|
@okinawaa conflict 해결 부탁드려요 |
okinawaa
force-pushed
the
remove-hangul-includes
branch
from
3b1845e
to
18c264a
Compare
okinawaa
added a commit
that referenced
this pull request
Aug 4, 2024
okinawaa
added a commit
that referenced
this pull request
Aug 4, 2024
okinawaa
added a commit
that referenced
this pull request
Aug 5, 2024
* feat: 문자열에서 한글을 추출해주는 extractHangul 함수를 제거합니다 (#185) * remove extrachHangul * Create cyan-tigers-sneeze.md --------- Co-authored-by: Jonghyeon Ko <[email protected]> * feat: disassembleHangul, disassemble, disassembleHangulToGroup 함수에서 hangul이라는 글자를 제거합니다 (#184) * dissemble관련 메서드에서 hangul이름을 제거합니다 * 누락된 부분 수정 * resolve conflit * Create late-beers-hang.md * diassembleHangul to diassemble --------- Co-authored-by: Jonghyeon Ko <[email protected]> * remove hangulIncludes (#188) * feat: 한글의 두음을 반환해주는 acronymizeHangul 함수를 제거합니다. (#180) * remove acronymize * Create weak-walls-sniff.md --------- Co-authored-by: Jonghyeon Ko <[email protected]> * feat: getChoseng을 utils에서 별도 함수로 분리합니다. (#192) * getChoseong분리 * write test code * getChoseong import * remove useless import statemenet * remove unused file * feat: `canBeChoseong`, `canBeJungseong`, `canBeJongseong` 을 utils에서 별도 함수로 분리합니다. (#193) * canBe series를 별도 함수로 분리합니다 * add change set * feat: `hasBatchim` 을 utils에서 별도 함수로 분리합니다. (#195) * hasBatchim * resolve type error * add change set * hasProperty, hasValueInReadOnlyStringList를 internal folder 로 옮깁니다 * resolve test error * move with test code * feat: choseongIncludes함수를 제거합니다. (#197) * remove choseongIncludes Co-authored-by: 서동휘 <[email protected]> * fix: remove 한글 * fix: amountToMoneyCurrency로 함수명 변경 * fix: amountToHangul로 함수명 수정 * fix: conflict * fix: filepath * fix: import 방식 변경 및 CHANGELOG restore * Create kind-birds-provide.md --------- Co-authored-by: 박찬혁 <[email protected]> Co-authored-by: Jonghyeon Ko <[email protected]> Co-authored-by: 서동휘 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
hangulIncludes 함수를 삭제합니다 #176 에서 논의한 결과, hangulIncludes는 삭제하기로 합니다.
개발자에 따라 hangulIncludes를 아래와 같이 사용하는 경우 true, false 둘 중 어떤 것을 반환하는게 맞을지 다르게 판단하는 경우가 존재합니다.
hangulIncludes('사과', '삭'); //hangulIncludes는 이미 제공해주는
disassembleHangul함수를 사용해서 사용자가 직접 구현할 수 있고, 더 다양한 유즈케이스까지 대응하는 hangulIncludes를 만들 수 있기때문에 es-hangul에서는 제공해주지 않으면 좋겠다고 생각해서 제거합니다.PR Checklist