Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sonarr - inclide_serise added to get_wanted #115

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

marksie1988
Copy link
Collaborator

@marksie1988 marksie1988 commented Jun 28, 2022

Description

Adds new arg include_series for the get_wanted method in Sonarr

Related issues

fixes #114

Motivation and Context

Adds missing functionality

How has this been tested

Tested in lab

Types of changes

  • Docs change / refactoring.
  • Non-breaking change (fix or feature that wouldn't cause existing functionality to change/break).
  • Breaking change (fix or feature that would cause existing functionality to change/break).

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes don't generate new warnings.
  • I have read the CONTRIBUTING document.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests pass.

@marksie1988 marksie1988 added the type/feature New feature or request label Jun 28, 2022
@sourcery-ai
Copy link

sourcery-ai bot commented Jun 28, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.77%.

Quality metrics Before After Change
Complexity 0.53 ⭐ 0.58 ⭐ 0.05 👎
Method Length 24.41 ⭐ 24.74 ⭐ 0.33 👎
Working memory 5.60 ⭐ 5.89 ⭐ 0.29 👎
Quality 90.07% 89.30% -0.77% 👎
Other metrics Before After Change
Lines 444 448 4
Changed files Quality Before Quality After Quality Change
pyarr/sonarr.py 90.07% ⭐ 89.30% ⭐ -0.77% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
pyarr/sonarr.py SonarrAPI._series_json 4 ⭐ 80 🙂 12 😞 64.24% 🙂 Extract out complex expressions
pyarr/sonarr.py SonarrAPI.get_wanted 1 ⭐ 44 ⭐ 13 😞 71.25% 🙂 Extract out complex expressions
pyarr/sonarr.py SonarrAPI.add_series 0 ⭐ 40 ⭐ 11 😞 76.21% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@marksie1988 marksie1988 merged commit c49fbb8 into master Jun 28, 2022
@marksie1988 marksie1988 deleted the 114-sonarr_add_include_series_to_get_wanted branch June 2, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sonarr: Add include series to get_wanted
1 participant