Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix errors in tests #129

Merged
merged 1 commit into from
Apr 6, 2023
Merged

test: fix errors in tests #129

merged 1 commit into from
Apr 6, 2023

Conversation

marksie1988
Copy link
Collaborator

Description

Fixes some errors seen in the new test modules

Related issues

Motivation and Context

How has this been tested

Types of changes

  • Docs change / refactoring.
  • Non-breaking change (fix or feature that wouldn't cause existing functionality to change/break).
  • Breaking change (fix or feature that would cause existing functionality to change/break).

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes don't generate new warnings.
  • I have read the CONTRIBUTING document.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests pass.

@marksie1988 marksie1988 added the type/ci CI related changes label Apr 6, 2023
@marksie1988 marksie1988 merged commit 674b063 into master Apr 6, 2023
@marksie1988 marksie1988 deleted the fix-test-failures branch June 2, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type/ci CI related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marksie1988