Skip to content

Commit

Permalink
fix: Resolves minor UI bugs.
Browse files Browse the repository at this point in the history
- Fixes update time of the keywords table is not aligned correctly in desktop.
- Fixes Content layout shift caused by the Domain Header absence.
- Fixes Footer causingpage scrollbar to appear.
  • Loading branch information
towfiqi committed Mar 2, 2024
1 parent bb4a684 commit 50160f5
Show file tree
Hide file tree
Showing 8 changed files with 11 additions and 8 deletions.
2 changes: 1 addition & 1 deletion components/ideas/KeywordIdeasTable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ const IdeasKeywordsTable = ({

return (
<div>
<div className='domKeywords flex flex-col bg-[white] rounded-md text-sm border mb-8'>
<div className='domKeywords flex flex-col bg-[white] rounded-md text-sm border mb-5'>
{selectedKeywords.length > 0 && (
<div className='font-semibold text-sm py-4 px-8 text-gray-500 '>
<div className={`inline-block ${isResearchPage ? ' mr-2' : ''}`}>Add Keywords to Tracker</div>
Expand Down
2 changes: 1 addition & 1 deletion components/insight/Insight.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ const SCInsight = ({ insight, isLoading = true, isConsoleIntegrated = true, doma

return (
<div>
<div className='domKeywords flex flex-col bg-[white] rounded-md text-sm border mb-8'>
<div className='domKeywords flex flex-col bg-[white] rounded-md text-sm border mb-5'>
<div className='domKeywords_filters py-4 px-6 flex flex-col justify-between
text-sm text-gray-500 font-semibold border-b-[1px] lg:border-0 lg:flex-row'>
<div>
Expand Down
2 changes: 1 addition & 1 deletion components/keywords/Keyword.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ const Keyword = (props: KeywordProps) => {
</div>

<div
className='inline-block mt-[4] top-[-5px] relative lg:flex-1 lg:m-0'>
className='inline-block mt-[4] top-[-5px] relative lg:flex-1 lg:m-0 lg:top-0'>
<span className='mr-2 lg:hidden'><Icon type="clock" size={14} color="#999" /></span>
<TimeAgo title={dayjs(lastUpdated).format('DD-MMM-YYYY, hh:mm:ss A')} date={lastUpdated} />
</div>
Expand Down
2 changes: 1 addition & 1 deletion components/keywords/KeywordsTable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ const KeywordsTable = (props: KeywordsTableProps) => {

return (
<div>
<div className='domKeywords flex flex-col bg-[white] rounded-md text-sm border mb-8'>
<div className='domKeywords flex flex-col bg-[white] rounded-md text-sm border mb-5'>
{selectedKeywords.length > 0 && (
<div className='font-semibold text-sm py-4 px-8 text-gray-500 '>
<ul className=''>
Expand Down
2 changes: 1 addition & 1 deletion components/keywords/SCKeywordsTable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ const SCKeywordsTable = ({ domain, keywords = [], isLoading = true, isConsoleInt

return (
<div>
<div className='domKeywords flex flex-col bg-[white] rounded-md text-sm border mb-8'>
<div className='domKeywords flex flex-col bg-[white] rounded-md text-sm border mb-4'>
{selectedKeywords.length > 0 && (
<div className='font-semibold text-sm py-4 px-8 text-gray-500 '>
<ul className=''>
Expand Down
3 changes: 2 additions & 1 deletion pages/domain/[slug]/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,14 @@ const SingleDomain: NextPage = () => {
<Sidebar domains={theDomains} showAddModal={() => setShowAddDomain(true)} />
<div className="domain_kewywords px-5 pt-10 lg:px-0 lg:pt-8 w-full">
{activDomain && activDomain.domain
&& <DomainHeader
? <DomainHeader
domain={activDomain}
domains={theDomains}
showAddModal={setShowAddKeywords}
showSettingsModal={setShowDomainSettings}
exportCsv={() => exportCSV(theKeywords, activDomain.domain)}
/>
: <div className='w-full lg:h-[100px]'></div>
}
<KeywordsTable
isLoading={keywordsLoading}
Expand Down
3 changes: 2 additions & 1 deletion pages/domain/console/[slug]/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ const DiscoverPage: NextPage = () => {
<Sidebar domains={theDomains} showAddModal={() => setShowAddDomain(true)} />
<div className="domain_kewywords px-5 pt-10 lg:px-0 lg:pt-8 w-full">
{activDomain && activDomain.domain
&& <DomainHeader
? <DomainHeader
domain={activDomain}
domains={theDomains}
showAddModal={() => console.log('XXXXX')}
Expand All @@ -66,6 +66,7 @@ const DiscoverPage: NextPage = () => {
scFilter={scDateFilter}
setScFilter={(item:string) => setSCDateFilter(item)}
/>
: <div className='w-full lg:h-[100px]'></div>
}
<SCKeywordsTable
isLoading={keywordsLoading || isFetching}
Expand Down
3 changes: 2 additions & 1 deletion pages/domain/insight/[slug]/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ const InsightPage: NextPage = () => {
<Sidebar domains={theDomains} showAddModal={() => setShowAddDomain(true)} />
<div className="domain_kewywords px-5 pt-10 lg:px-0 lg:pt-8 w-full">
{activDomain && activDomain.domain
&& <DomainHeader
? <DomainHeader
domain={activDomain}
domains={theDomains}
showAddModal={() => console.log('XXXXX')}
Expand All @@ -66,6 +66,7 @@ const InsightPage: NextPage = () => {
scFilter={scDateFilter}
setScFilter={(item:string) => setSCDateFilter(item)}
/>
: <div className='w-full lg:h-[100px]'></div>
}
<SCInsight
isLoading={false}
Expand Down

0 comments on commit 50160f5

Please sign in to comment.