Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Towhee logging module #2640

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Optimize Towhee logging module #2640

merged 1 commit into from
Jul 26, 2023

Conversation

Chiiizzzy
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 97.14% and project coverage change: +0.12% 🎉

Comparison is base (2e2f14a) 75.88% compared to head (a9fe1dd) 76.01%.
Report is 3 commits behind head on main.

❗ Current head a9fe1dd differs from pull request most recent head 5cfc712. Consider uploading reports for the commit 5cfc712 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2640      +/-   ##
==========================================
+ Coverage   75.88%   76.01%   +0.12%     
==========================================
  Files         405      407       +2     
  Lines       20751    20820      +69     
  Branches     2754     2763       +9     
==========================================
+ Hits        15747    15826      +79     
+ Misses       4116     4104      -12     
- Partials      888      890       +2     
Files Changed Coverage Δ
towhee/utils/log.py 95.83% <95.34%> (-4.17%) ⬇️
towhee/config/__init__.py 100.00% <100.00%> (ø)
towhee/config/log_config.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@junjiejiangjjj
Copy link
Contributor

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Chiiizzzy, junjiejiangjjj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit bff60a5 into towhee-io:main Jul 26, 2023
5 checks passed
@Chiiizzzy Chiiizzzy deleted the log branch July 26, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants