Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux: Empty environment variables should use defaults #29

Closed
domdfcoding opened this issue Jul 26, 2021 · 2 comments · Fixed by #30
Closed

Linux: Empty environment variables should use defaults #29

domdfcoding opened this issue Jul 26, 2021 · 2 comments · Fixed by #30
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@domdfcoding
Copy link
Contributor

This was originally reported in the appdirs tracker: ActiveState/appdirs#130

The gist is that, per the XDG spec, platformdirs should treat environment variables that are set but empty as if they were unset.


I came across this as part of pypa/pip#10202

pip patches appdirs to work around this: https://github.com/pypa/pip/blob/867bbb00ccb0506095e19a0e111ce06ce71a2495/tools/vendoring/patches/appdirs.patch#L47-L54

There is some prior discussion in pypa/pip#7501 (comment)

@gaborbernat
Copy link
Member

Can you open a PR to address it? Thanks!

@gaborbernat gaborbernat added enhancement New feature or request help wanted Extra attention is needed labels Jul 26, 2021
@papr
Copy link
Contributor

papr commented Jul 28, 2021

I will give this a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants