chore: bump rust version and fix lints (#47)

Signed-off-by: Henry Schreiner <[email protected]>

Cargo.toml

@@ -29,6 +29,9 @@ all = "warn"
 pedantic = "warn"
 nursery = "warn"
 
+[lints.rust]
+unexpected_cfgs = { level = "warn", check-cfg = ['cfg(tarpaulin_include)'] }
+
 [dev-dependencies]
 rstest = { version = "0.19.0" } # parametrized tests
 indoc = { version = "2.0.5" }   # dedented test cases for literal strings

rust-toolchain.toml

@@ -1,2 +1,2 @@
 [toolchain]
-channel = "1.77"
+channel = "1.81"

rust/src/build_system.rs

@@ -2,7 +2,7 @@ use crate::helpers::array::{sort, transform};
 use crate::helpers::pep508::{format_requirement, get_canonic_requirement_name};
 use crate::helpers::table::{for_entries, reorder_table_keys, Tables};
 
-pub fn fix(tables: &mut Tables, keep_full_version: bool) {
+pub fn fix(tables: &Tables, keep_full_version: bool) {
     let table_element = tables.get("build-system");
     if table_element.is_none() {
         return;
@@ -35,8 +35,8 @@ mod tests {
     fn evaluate(start: &str, keep_full_version: bool) -> String {
         let root_ast = parse(start).into_syntax().clone_for_update();
         let count = root_ast.children_with_tokens().count();
-        let mut tables = Tables::from_ast(&root_ast);
-        fix(&mut tables, keep_full_version);
+        let tables = Tables::from_ast(&root_ast);
+        fix(&tables, keep_full_version);
         let entries = tables
             .table_set
             .iter()

rust/src/global.rs

@@ -3,7 +3,7 @@ use taplo::syntax::Lang;
 
 use crate::helpers::table::Tables;
 
-pub fn reorder_tables(root_ast: &SyntaxNode<Lang>, tables: &mut Tables) {
+pub fn reorder_tables(root_ast: &SyntaxNode<Lang>, tables: &Tables) {
     tables.reorder(
         root_ast,
         &[
@@ -161,8 +161,8 @@ mod tests {
     )]
     fn test_reorder_table(#[case] start: &str, #[case] expected: &str) {
         let root_ast = parse(start).into_syntax().clone_for_update();
-        let mut tables = Tables::from_ast(&root_ast);
-        reorder_tables(&root_ast, &mut tables);
+        let tables = Tables::from_ast(&root_ast);
+        reorder_tables(&root_ast, &tables);
         let opt = Options {
             column_width: 1,
             ..Options::default()

rust/src/helpers/array.rs

@@ -39,8 +39,7 @@ where
                 == Some(COMMA);
             let multiline = array_node
                 .children_with_tokens()
-                .find(|e| e.kind() == NEWLINE)
-                .is_some();
+                .any(|e| e.kind() == NEWLINE);
             let mut value_set = Vec::<Vec<SyntaxElement>>::new();
             let entry_set = RefCell::new(Vec::<SyntaxElement>::new());
             let mut key_to_pos = HashMap::<String, usize>::new();

rust/src/helpers/table.rs

@@ -17,7 +17,7 @@ pub struct Tables {
 }
 
 impl Tables {
-    pub(crate) fn get(&mut self, key: &str) -> Option<Vec<&RefCell<Vec<SyntaxElement>>>> {
+    pub(crate) fn get(&self, key: &str) -> Option<Vec<&RefCell<Vec<SyntaxElement>>>> {
         if self.header_to_pos.contains_key(key) {
             let mut res = Vec::<&RefCell<Vec<SyntaxElement>>>::new();
             for pos in &self.header_to_pos[key] {
@@ -75,7 +75,7 @@ impl Tables {
         }
     }
 
-    pub fn reorder(&mut self, root_ast: &SyntaxNode, order: &[&str]) {
+    pub fn reorder(&self, root_ast: &SyntaxNode, order: &[&str]) {
         let mut to_insert = Vec::<SyntaxElement>::new();
         let order = calculate_order(&self.header_to_pos, &self.table_set, order);
         let mut next = order.clone();

rust/src/main.rs

@@ -52,15 +52,15 @@ pub fn format_toml(content: &str, opt: &Settings) -> String {
     let root_ast = parse(content).into_syntax().clone_for_update();
     let mut tables = Tables::from_ast(&root_ast);
 
-    build_system::fix(&mut tables, opt.keep_full_version);
+    build_system::fix(&tables, opt.keep_full_version);
     project::fix(
         &mut tables,
         opt.keep_full_version,
         opt.max_supported_python,
         opt.min_supported_python,
     );
     ruff::fix(&mut tables);
-    reorder_tables(&root_ast, &mut tables);
+    reorder_tables(&root_ast, &tables);
 
     let options = Options {
         align_entries: false,         // do not align by =