Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API #216

Merged
merged 1 commit into from
May 14, 2024
Merged

Add API #216

merged 1 commit into from
May 14, 2024

Conversation

gaborbernat
Copy link
Member

@gaborbernat gaborbernat commented May 14, 2024

👍

Signed-off-by: Bernát Gábor <[email protected]>
@gaborbernat
Copy link
Member Author

@abravalheri can you confirm this is good enough for you? Can't give sadly pass in string functionality, but this should be close enough.

@gaborbernat gaborbernat merged commit aa448ca into tox-dev:main May 14, 2024
10 checks passed
@gaborbernat gaborbernat deleted the api branch May 14, 2024 20:58
@abravalheri
Copy link
Contributor

Thank you very much for having a go at this.

I suppose that the next best thing for applications that want to manipulate in-memory strings directly would be to use pyproject-fmt-rust and copy the defaults from pyproject-fmt, right?

There is the obvious drawback that the pyproject-fmt defaults might drift with time (and/or) new configuration options may be added, so the application would have to catch up, but at least that would eliminate the need for temporary files...

@gaborbernat
Copy link
Member Author

Thank you very much for having a go at this.

I suppose that the next best thing for applications that want to manipulate in-memory strings directly would be to use pyproject-fmt-rust and copy the defaults from pyproject-fmt, right?

There is the obvious drawback that the pyproject-fmt defaults might drift with time (and/or) new configuration options may be added, so the application would have to catch up, but at least that would eliminate the need for temporary files...

Sure, but note the settings class is not backwards compatible so you'll need to pin the project. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants