Allow ConfigSet.add_config to receive parameterized generics for of_type.
#3288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
changed the title
ConfigSet.add_config to receive parameterized generics for of_type.
ssbarnea
force-pushed
the
fix/type
branch
2 times, most recently
from
f20e12f
to
c60aab8
Compare
gaborbernat
requested changes
May 29, 2024
for more information, see https://pre-commit.ci
But of course! Note that I was not able to use pytest skip marks to avoid py38 because interpreter failed to load the test file itself. Still, using an if before the test definition worked fine. |
gaborbernat
approved these changes
May 31, 2024
seyidaniels
pushed a commit
to seyidaniels/tox
that referenced
this pull request
Jun 10, 2024
…f_type`. (tox-dev#3288) * Allow use of list[str] inside plugins Fixes: tox-dev#3287 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
ConfigSet.add_configto receive parameterized generics forof_type.Fixes: #3287
tox -e fix)docs/changelogfolder