Add windir to the default list of pass_env variables on Windows
#3303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborbernat
requested changes
Jul 1, 2024
kurtmckee
force-pushed
the
add-windir-to-default-pass_env
branch
from
7aff1dc
to
8aa94b1
Compare
|
Oof, this is harder when I'm not in front of my Windows PC to test locally. I'll update this again! |
kurtmckee
force-pushed
the
add-windir-to-default-pass_env
branch
from
8aa94b1
to
b10b87d
Compare
|
It looks like the |
5 tasks
naa0yama
referenced
this pull request
in naa0yama/PythonBoilerplate
Jul 11, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [tox](https://togithub.com/tox-dev/tox) ([changelog](https://tox.wiki/en/latest/changelog.html)) | `~4.15.0` -> `~4.16.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>tox-dev/tox (tox)</summary> ### [`v4.16.0`](https://togithub.com/tox-dev/tox/releases/tag/4.16.0) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.15.1...4.16.0) <!-- Release notes generated using configuration in .github/release.yml at 4.16.0 --> #### What's Changed - Fix two small documentation issues by [@​srenfo](https://togithub.com/srenfo) in [https://github.com/tox-dev/tox/pull/3297](https://togithub.com/tox-dev/tox/pull/3297) - Fix tests after new setuptools by [@​gaborbernat](https://togithub.com/gaborbernat) in [https://github.com/tox-dev/tox/pull/3299](https://togithub.com/tox-dev/tox/pull/3299) - Add `windir` to the default list of `pass_env` variables on Windows by [@​kurtmckee](https://togithub.com/kurtmckee) in [https://github.com/tox-dev/tox/pull/3303](https://togithub.com/tox-dev/tox/pull/3303) #### New Contributors - [@​srenfo](https://togithub.com/srenfo) made their first contribution in [https://github.com/tox-dev/tox/pull/3297](https://togithub.com/tox-dev/tox/pull/3297) **Full Changelog**: tox-dev/tox@4.15.1...4.16.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/naa0yama/PythonBoilerplate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuOSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkYXRhc291cmNlOnB5cGkiLCJkZXBUeXBlOmRldiIsIm1hbmFnZXI6cG9ldHJ5IiwicmVub3ZhdGUiLCJ1cGRhdGUtbWlub3IiLCJ2ZXJzaW9uaW5nOnBvZXRyeSJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
hofbi
referenced
this pull request
in luminartech/dev-tools
Aug 9, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [tox](https://togithub.com/tox-dev/tox) ([changelog](https://tox.wiki/en/latest/changelog.html)) | `==4.15.1` -> `==4.17.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>tox-dev/tox (tox)</summary> ### [`v4.17.1`](https://togithub.com/tox-dev/tox/releases/tag/4.17.1) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.17.0...4.17.1) <!-- Release notes generated using configuration in .github/release.yml at 4.17.1 --> #### What's Changed - Restore limited `<major>.<minor>` environment name support by [@​gaborbernat](https://togithub.com/gaborbernat) in [https://github.com/tox-dev/tox/pull/3319](https://togithub.com/tox-dev/tox/pull/3319) - fix(tox_env.python): do not process absolute paths to interpreter as PythonSpec by [@​paveldikov](https://togithub.com/paveldikov) in [https://github.com/tox-dev/tox/pull/3311](https://togithub.com/tox-dev/tox/pull/3311) #### New Contributors - [@​paveldikov](https://togithub.com/paveldikov) made their first contribution in [https://github.com/tox-dev/tox/pull/3311](https://togithub.com/tox-dev/tox/pull/3311) **Full Changelog**: tox-dev/tox@4.17.0...4.17.1 ### [`v4.17.0`](https://togithub.com/tox-dev/tox/releases/tag/4.17.0) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.16.0...4.17.0) <!-- Release notes generated using configuration in .github/release.yml at 4.17.0 --> #### What's Changed - Fix user guide system overview so nodes don't overlap. by [@​Tom01098](https://togithub.com/Tom01098) in [https://github.com/tox-dev/tox/pull/3307](https://togithub.com/tox-dev/tox/pull/3307) - Table with list of default env vars per OS by [@​seyidaniels](https://togithub.com/seyidaniels) in [https://github.com/tox-dev/tox/pull/3291](https://togithub.com/tox-dev/tox/pull/3291) - Add GraalPy and test both GraalPy and Jython env identifiers by [@​timfel](https://togithub.com/timfel) in [https://github.com/tox-dev/tox/pull/3312](https://togithub.com/tox-dev/tox/pull/3312) - Add on platform constat to core by [@​gaborbernat](https://togithub.com/gaborbernat) in [https://github.com/tox-dev/tox/pull/3315](https://togithub.com/tox-dev/tox/pull/3315) #### New Contributors - [@​Tom01098](https://togithub.com/Tom01098) made their first contribution in [https://github.com/tox-dev/tox/pull/3307](https://togithub.com/tox-dev/tox/pull/3307) - [@​timfel](https://togithub.com/timfel) made their first contribution in [https://github.com/tox-dev/tox/pull/3312](https://togithub.com/tox-dev/tox/pull/3312) **Full Changelog**: tox-dev/tox@4.16.0...4.17.0 ### [`v4.16.0`](https://togithub.com/tox-dev/tox/releases/tag/4.16.0) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.15.1...4.16.0) <!-- Release notes generated using configuration in .github/release.yml at 4.16.0 --> #### What's Changed - Fix two small documentation issues by [@​srenfo](https://togithub.com/srenfo) in [https://github.com/tox-dev/tox/pull/3297](https://togithub.com/tox-dev/tox/pull/3297) - Fix tests after new setuptools by [@​gaborbernat](https://togithub.com/gaborbernat) in [https://github.com/tox-dev/tox/pull/3299](https://togithub.com/tox-dev/tox/pull/3299) - Add `windir` to the default list of `pass_env` variables on Windows by [@​kurtmckee](https://togithub.com/kurtmckee) in [https://github.com/tox-dev/tox/pull/3303](https://togithub.com/tox-dev/tox/pull/3303) #### New Contributors - [@​srenfo](https://togithub.com/srenfo) made their first contribution in [https://github.com/tox-dev/tox/pull/3297](https://togithub.com/tox-dev/tox/pull/3297) **Full Changelog**: tox-dev/tox@4.15.1...4.16.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/luminartech/dev-tools). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yMC4xIiwidXBkYXRlZEluVmVyIjoiMzguMjAuMSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
windirto the default list of Windowspass_envenvironment variables.windiris a system environment variable that has existed since Windows 95. LikeTMPandUSERPROFILE, it is assumed to exist and no software documents that it should be set. It is often difficult to figure out that crashes and errors are caused by a missingwindirenvironment variable.This change allows Windows software that relies on
windirto work out-of-the-box.Note
The canonical spelling of
windiris lowercase. This PR uses an uppercase variant based on PR feedback.Fixes #3302
tox -e fix)docs/changelogfolder