Fixup the spec string for sys.executable #3327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous spec string was:
namespace(name='cpython', cache_tag='cpython-313', version=sys.version_info(major=3, minor=13, micro=0, releaselevel='candidate', serial=1), hexversion=51183809, _multiarch='x86_64-linux-gnu')313-True
When it was supposed to be:
cpython313-64
Fixes https://github.com/tox-dev/tox/pull/3325/files#r1718230254
Fixes https://github.com/tox-dev/tox/pull/3325/files#r1718246292
Adds tests for a new method.
gaborbernat
reviewed
Aug 15, 2024
gaborbernat
reviewed
Aug 17, 2024
The error was:
tests/tox_env/python/test_python_api.py:314:12: SLF001 Private member accessed: `_python_spec_for_sys_executable`
|
312 | mocker.patch.object(sys, "implementation", implementation)
313 | mocker.patch.object(sys, "maxsize", 2**arch // 2 - 1)
314 | spec = Python._python_spec_for_sys_executable()
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ SLF001
315 | assert spec.implementation == impl
316 | assert spec.major == major
|
Found 1 error.
gaborbernat
approved these changes
Aug 17, 2024
1 task
hofbi
pushed a commit
to luminartech/dev-tools
that referenced
this pull request
Sep 13, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [tox](https://redirect.github.com/tox-dev/tox) ([changelog](https://tox.wiki/en/latest/changelog.html)) | `==4.18.0` -> `==4.18.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>tox-dev/tox (tox)</summary> ### [`v4.18.1`](https://redirect.github.com/tox-dev/tox/releases/tag/4.18.1) [Compare Source](https://redirect.github.com/tox-dev/tox/compare/4.18.0...4.18.1) <!-- Release notes generated using configuration in .github/release.yml at 4.18.1 --> #### What's Changed - Fixup the spec string for sys.executable by [@​hroncok](https://redirect.github.com/hroncok) in [tox-dev/tox#3327 - Fix issue link in changelog by [@​schlamar](https://redirect.github.com/schlamar) in [tox-dev/tox#3332 - Properly document the `tox_env_teardown` hook by [@​kemzeb](https://redirect.github.com/kemzeb) in [tox-dev/tox#3333 - Add 3.13 to CI and bump deps by [@​gaborbernat](https://redirect.github.com/gaborbernat) in [tox-dev/tox#3339 #### New Contributors - [@​schlamar](https://redirect.github.com/schlamar) made their first contribution in [tox-dev/tox#3332 - [@​kemzeb](https://redirect.github.com/kemzeb) made their first contribution in [tox-dev/tox#3333 **Full Changelog**: tox-dev/tox@4.18.0...4.18.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/luminartech/dev-tools). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC43NC4xIiwidXBkYXRlZEluVmVyIjoiMzguNzQuMSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous spec string was:
When it was supposed to be:
Fixes https://github.com/tox-dev/tox/pull/3325/files#r1718230254
Fixes https://github.com/tox-dev/tox/pull/3325/files#r1718246292
Adds tests for a new method.
tox -e fix)docs/changelogfolder