catch invalid prepend_points (#34)

tpapp · Sep 7, 2022 · 87d60f8 · 87d60f8 · tpapp · Sep 7, 2022
1 parent e708a98
commit 87d60f8
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "MultistartOptimization"
 uuid = "3933049c-43be-478e-a8bb-6e0f7fd53575"
 authors = ["Tamas K. Papp <[email protected]>"]
-version = "0.2.0"
+version = "0.2.1"
 
 [deps]
 ArgCheck = "dce04be8-c92d-5529-be00-80e4d2c0e197"

diff --git a/src/tiktak.jl b/src/tiktak.jl
@@ -114,7 +114,9 @@ function multistart_minimization(multistart_method::TikTak, local_method,
                                  use_threads = true,
                                  prepend_points = Vector{Vector{Float64}}())
     @unpack quasirandom_N, initial_N, θ_min, θ_max, θ_pow = multistart_method
-    @unpack objective = minimization_problem
+    @unpack objective, lower_bounds, upper_bounds = minimization_problem
+    @argcheck(all(x -> all(lower_bounds .≤ x .≤ upper_bounds), prepend_points),
+              "prepend_points outside problem bounds")
     quasirandom_points = sobol_starting_points(minimization_problem, quasirandom_N,
                                                use_threads)
     initial_points = _keep_lowest(quasirandom_points, initial_N)

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -89,4 +89,5 @@ end
     r1 = multistart_minimization(MM, LM, P; use_threads = false, prepend_points = [z1])
     @test r1.value == vz1
     @test r1.location == z1
+    @test_throws ArgumentError multistart_minimization(MM, LM, P; use_threads = false, prepend_points = [lb .- 2])
 end