Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate dropping BouncyCastle dependency #4

Closed
tpeczek opened this issue Jan 19, 2018 · 5 comments
Closed

Investigate dropping BouncyCastle dependency #4

tpeczek opened this issue Jan 19, 2018 · 5 comments

Comments

@tpeczek
Copy link
Owner

tpeczek commented Jan 19, 2018

Currently this library has dependency on two different BouncyCastle builds. It would be perfect to drop the BouncyCastle dependency, but it requires new APIs in CoreFX/NetFX.

[DEPENDS ON] dotnet/runtime#17152
[DEPENDS ON] dotnet/runtime#22610
[DEPENDS ON] tpeczek/Lib.Net.Http.EncryptedContentEncoding#4

@clairernovotny
Copy link

Hi,

I recommend you use my Portable.BouncyCastle package. It's the official one and the PR with its changes will be brought into BC once the maintainers are ready with their next release.

It supports all platforms and is a drop-in replacement.

@tpeczek
Copy link
Owner Author

tpeczek commented Jan 29, 2018

Hi @onovotny,

Thank you for the suggestion. Indeed it seems to be a well maintained and popular version (especially in comparison to BouncyCastle.CoreClr). I think I'll first give it a go in Lib.Net.Http.EncryptedContentEncoding and then here.

@tpeczek tpeczek changed the title Drop BouncyCastle dependency Investigate dropping BouncyCastle dependency Feb 4, 2018
@tpeczek
Copy link
Owner Author

tpeczek commented Feb 4, 2018

Currently this library depends on Portable.BouncyCastle. In future it might be still worth to consider dropping the BouncyCastle dependency in favour of native CoreFX/NetFX APIs.

@tuwrraphael
Copy link

As I mentioned in an issue in web-push-libs/web-push-csharp , the required aes-gcm cipher will be available in .net core3 (it is already included in the preview 1).

@tpeczek
Copy link
Owner Author

tpeczek commented Feb 17, 2019

@tuwrraphael Yes. It's not enough to drop BouncyCastle entirely (ASN.1 reader/writer missing) but it should be enough to close tpeczek/Lib.Net.Http.EncryptedContentEncoding#4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants