Specify Redis gems as required dependencies #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the specs need to be updated for Redis 5: https://github.com/tpitale/mail_room/actions/runs/4961109521/jobs/8877471798 |
stanhu
force-pushed
the
sh-redis-namespace-required
branch
3 times, most recently
from
16d5f65
to
6a44dd4
Compare
We recently came across a Ruby 3 compatibility issue with redis-namespace and MailRoom that required updating to redis-namespace v1.8.x (https://github.com/resque/redis-namespace/blob/master/CHANGELOG.md). Since the gemspec did not specify a version, we have to install the required Redis gems by hand and missed the need for updating. Adjust tests to support both Redis v4 and v5 gems. Redis v4 may still be needed for Rails 6 compatibility.
stanhu
force-pushed
the
sh-redis-namespace-required
branch
from
6a44dd4
to
31953a9
Compare
|
@tpitale Curious what you think about this pull request. In general, I think we should move move of the development gems into required gems so we can be sure that the code here works against the specific gem versions, but I can understand that C extensions might be a concern. |
|
I think I worried about this because not everyone uses this delivery method. But I'll have to look on a computer the next chance I get. If you don't hear from me by Monday, don't hesitate to ping me again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently came across a Ruby 3 compatibility issue with redis-namespace and MailRoom that required updating to redis-namespace v1.8.x (https://github.com/resque/redis-namespace/blob/master/CHANGELOG.md). Since the gemspec did not specify a version, we have to install the required Redis gems by hand and missed the need for updating.
Adjust tests to support both Redis v4 and v5 gems. Redis v4 may still be needed for Rails 6 compatibility.