ESYS: Add OpenSSL error outputs to calls #2896
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreasFuchsTPM
requested changes
Aug 22, 2024
src/tss2-esys/esys_crypto_ossl.h
Outdated
| unsigned long err = ERR_get_error(); \ | ||
| char err_buffer[256]; \ | ||
| ERR_error_string_n(err, err_buffer, sizeof(err_buffer)); \ | ||
| LOG_ERROR("Failure %s", err_buffer); \ |
There was a problem hiding this comment.
Let's replace this with "OpenSSL reported: %s" or something similar ?
Additionally to the esys error log the OpenSSLx error message will be displayed. Fixes: tpm2-software#2892 Signed-off-by: Juergen Repp <[email protected]>
JuergenReppSIT
force-pushed
the
esys-add-ossl-err-log
branch
from
12f5a02
to
51bb7c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally to the esys error log the OpenSSLx error message will be displayed.
Fixes: #2892