Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gen_sdk_package.sh #402

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: gen_sdk_package.sh #402

wants to merge 1 commit into from

Conversation

teocns
Copy link

@teocns teocns commented Nov 2, 2023

tools/gen_sdk_package.sh redundantly packages symlinks pointing to the same SDK, resulting in duplicates

/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs $ ls -la
.
..
MacOSX.sdk
MacOSX13.3.sdk -> MacOSX.sdk
MacOSX13.sdk -> MacOSX.sdk

$ ./gen_sdk_package.sh
found Xcode: /Applications/Xcode.app
packaging MacOSX13.3 SDK (this may take several minutes) ...
packaging MacOSX13 SDK (this may take several minutes) ...

In this case MacOS13 and MacOS13.3 are symlinks that point to the same SDK. The script should be able to detect this and not package the same SDK twice.

The implemented change filters out SDK symlink entries that reference the same SDK, retaining the one with the verbose-most version (minor)

Filter out SDK symlink entries that reference the same SDK, retaining the most verbose version name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant