Report location provider #348
Conversation
oliv3
changed the title
oliv3
force-pushed
the
locationProvider
branch
from
832414c
to
7c71071
Compare
| @@ -91,6 +91,11 @@ public void onUpgrade(SQLiteDatabase db, int oldVersion, int newVersion) { | |||
| onCreate(db); | |||
| } | |||
|
|
|||
| public void onDowngrade(SQLiteDatabase db, int oldVersion, int newVersion) { | |||
| db.execSQL("DROP TABLE IF EXISTS position;"); | |||
There was a problem hiding this comment.
I stuck with what was done for now when upgrading the schema.
Also, SQLite supports a limited subset of ALTER TABLE (https://www.sqlite.org/lang_altertable.html): there's no easy way to drop a column; and from what I know the idea is to keep the application simple.
At least this prevents the application from crashing.
There was a problem hiding this comment.
There was a problem hiding this comment.
I guess you meant to say that you have to manually download APK. I don't think very many people do that.
As for the original comment, ideally database should be empty anyway if you have internet connection. Traccar Client uploads data automatically and removes it from local database.
There was a problem hiding this comment.
Right, regular Google Play Store users can't downgrade. But as seen @luke-jr did, so everything can happen.
There was a problem hiding this comment.
As for the original comment, I'm also fine with the way upgrading is done.
There was a problem hiding this comment.
I did it by copying the apk off another phone that hadn't upgraded yet.
oliv3
force-pushed
the
locationProvider
branch
3 times, most recently
from
1ffa774
to
312e9cb
Compare
oliv3
force-pushed
the
locationProvider
branch
from
312e9cb
to
ea0b8c9
Compare
There was a problem hiding this comment.
"setting" as a name is pretty ambigous.
Re database changes: I wonder if it would make sense to just build the query string upfront and store that. Then upgrades can just send the old data as-is despite it missing new fields. (And future downgrades would safely send even the new fields!)
oliv3
force-pushed
the
locationProvider
branch
from
ea0b8c9
to
18004aa
Compare
|
A better name ? |
|
Database changes, I'll leave that to you. That's a harsh optimization for sure. |
|
But yes, if the job is only to replay HTTP POSTs, why not just drop Sqlite ? |
|
"location-source" or something like that maybe? |
|
@luke-jr no, for "setting". I'd be fine with "tuning", because that's what it does. "complicatedHeuristicName" would be too long. |
oliv3
force-pushed
the
locationProvider
branch
from
721568c
to
252407a
Compare
|
@tananaev ping ? |
oliv3
force-pushed
the
locationProvider
branch
from
87990cd
to
94e589a
Compare
No description provided.