Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set labels on pods #31

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

m-wrzesien
Copy link

Added option to add custom labels to pod.

@m-wrzesien
Copy link
Author

@tananaev and @tamcore
Can i ask for review please?

@tananaev
Copy link
Member

tananaev commented Sep 9, 2024

I think you need to add a more detailed description on what this is for.

@m-wrzesien
Copy link
Author

podLabels allows user to set arbitrary label on traccar pod.
This allows setting some custom labels.
As for the use case, some cluster operators have set of labels which they want to have on pods and this feature allows for that.

This pattern is used in many helm chart repositories:

@m-wrzesien
Copy link
Author

@tananaev
I've added comment with description.
If you have a time, please take a look at it.

By the way, should i mention you or anyone else if I made any changes/add a new comment to PR?

@tananaev
Copy link
Member

Thanks for adding the description, but I don't think I'm qualified enough to review this. So let's wait for others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants