add icons and login #1062
add icons and login #1062
Conversation
|
What's the point of the mail icon? |
|
give it a little more style I plan to do the same in different parts of the modern web interface. |
|
I personally like cleaner minimalist look. Let's do only the show password icon for now. For any future changes please discuss first before implementing it. |
|
Ready friend, you send it, I also have it added in the registration part so that it also shows it in the registration area. What do I do, will it be that I make a new code just by entering the password to show it? And I also do it in the registry? |
|
It doesn't look like you addressed the comment. I still see mail and other unrelated icons. |
|
ready friend check again just apply it to what you allow me to add |
| @@ -57,6 +58,11 @@ const LoginPage = () => { | |||
| const [email, setEmail] = usePersistedState('loginEmail', ''); | |||
| const [password, setPassword] = useState(''); | |||
|
|
|||
| const [showPassword, setShowPassword] = useState(false); | |||
| const handleClickShowPassword = () => { | |||
There was a problem hiding this comment.
Please inline these callbacks.
| @@ -38,6 +39,11 @@ const RegisterPage = () => { | |||
| const [password, setPassword] = useState(''); | |||
| const [snackbarOpen, setSnackbarOpen] = useState(false); | |||
|
|
|||
| const [showPassword, setShowPassword] = useState(false); | |||
| const handleClickShowPassword = () => { | |||
There was a problem hiding this comment.
ps from what it translates for me I understand that I must add the lines that you are showing me,
but I already have that added to the code
There was a problem hiding this comment.
No, you should remove them and inline the code. There's no point to have separate methods with just one line implementation.
There was a problem hiding this comment.
this change is missing in RegisterPage.js
type={showPassword ? 'text' : 'password'}
to improve the user interface