Add option to view one attribute in the sidebar #1254
Conversation
|
I don't think it makes sense to have a dedicated checkbox just for the speed. We should probably support any position attribute. |
Masaneth
changed the title
|
I had not thought about the possibility to see any attribute, it is better more customizable, it is implemented in the second commit. Now you can choose which attribute to display or not display any
|
| label={t('deviceShowAttribute')} | ||
| value={attributes.deviceShowAttribute || ''} | ||
| onChange={(e) => { | ||
| setAttributes({ ...attributes, deviceShowAttribute: e.target.value }); |
There was a problem hiding this comment.
Is there an easy way to clear this attribute when empty value is selected?
There was a problem hiding this comment.
In the existing code of the page, attributes are normally not removed when they are set with empty values; they are kept with an empty string or a default value. To maintain consistency, I manage empty values in a similar way:
There was a problem hiding this comment.
OK, I think it's ok to keep as is. It's a bit different though because most of the other attributes are basically expected to have something. This one is basically optional.
Add option to view speed of the device in the sidebar
With the option to activate it or not to each user's taste.