Show version on login screen #1256
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm personally against adding this. I don't see enough value in it. |
|
@tananaev I thought its nothing big because there is an option to disable it from the config. |
|
It adds another thing to maintain and worry about. Even if it's small, we need to carefully think about everything we add. |
|
Mm. It's up to you. I don't think that will be a big deal to maintain this. It's a simple UI change. |
|
@tananaev what do you think? do I need to withdraw my PR? |
|
We can keep it open and see how much interest is there. |
|
Okay. Lets see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the system to show version number on the initial authentication pages
Regarding the feature requested #1245