Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reviews must be presented in text format, not in JSON #90

Closed
h1alexbel opened this issue Apr 12, 2024 · 3 comments
Closed

Reviews must be presented in text format, not in JSON #90

h1alexbel opened this issue Apr 12, 2024 · 3 comments
Assignees
@h1alexbel
Labels
bug Something isn't working

Comments

@h1alexbel
Copy link
Contributor

For now, we present reviews as JSON array and compile the prompt:

code-review-action/src/main/java/git/tracehub/codereview/action/prompt/AnalysisPrompt.java

Line 55 in ccff996

private final JsonArray reviews;

code-review-action/src/main/java/git/tracehub/codereview/action/prompt/AnalysisPrompt.java

Line 101 in ccff996

this.reviews.toString()

in some responses LLM mentions that JSON and it confuses the users
@h1alexbel h1alexbel added the bug Something isn't working label Apr 12, 2024
@h1alexbel h1alexbel self-assigned this Apr 12, 2024
@h1alexbel h1alexbel changed the title Reviews must be presented in text format not in JSON Reviews must be presented in text format, not in JSON Apr 12, 2024
h1alexbel pushed a commit that referenced this issue Apr 12, 2024
fix(#90): TextReviews
e28359b
h1alexbel pushed a commit that referenced this issue Apr 12, 2024
fix(#90): TextChanges
1d794eb
h1alexbel pushed a commit that referenced this issue Apr 12, 2024
fix(#90): AnalysisPrompt
28aca5f
@h1alexbel h1alexbel mentioned this issue Apr 12, 2024
Merged
h1alexbel pushed a commit that referenced this issue Apr 12, 2024
fix(#90): clean for qulice
e9e8d4e
@h1alexbel
Copy link
Contributor Author

@rultor release, tag is 0.1.22

@rultor
Copy link
Collaborator

rultor commented Apr 12, 2024

@rultor release, tag is 0.1.22

@h1alexbel OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

rultor commented Apr 12, 2024

@rultor release, tag is 0.1.22

@h1alexbel Done! FYI, the full log is here (took me 3min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@h1alexbel h1alexbel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rultor @h1alexbel