Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#2): JsonComments, comments per review id, cov up #28

Merged
merged 4 commits into from
Apr 1, 2024

Conversation

h1alexbel
Copy link
Contributor

@h1alexbel h1alexbel commented Apr 1, 2024

ref #2


PR-Codex overview

This PR focuses on refactoring classes related to GitHub pull requests.

Detailed summary

  • Renamed JsonPull to PullRequest
  • Added MIT license header to new classes
  • Implemented GhRequest for GitHub API requests
  • Created Reviews and JsonComments classes for code reviews

The following files were skipped due to too many changes: src/main/java/git/tracehub/codereview/action/Entry.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 26.76%. Comparing base (697d76d) to head (0ceb34a).
Report is 11 commits behind head on master.

Files Patch % Lines
...racehub/codereview/action/github/JsonComments.java 0.00% 15 Missing ⚠️
...git/tracehub/codereview/action/github/Reviews.java 0.00% 13 Missing ⚠️
...ain/java/git/tracehub/codereview/action/Entry.java 0.00% 8 Missing ⚠️
...t/tracehub/codereview/action/github/GhRequest.java 0.00% 2 Missing ⚠️
...it/tracehub/codereview/action/github/Authored.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master      #28       +/-   ##
=============================================
- Coverage     58.82%   26.76%   -32.07%     
  Complexity        8        8               
=============================================
  Files             4        7        +3     
  Lines            34       71       +37     
=============================================
- Hits             20       19        -1     
- Misses           14       52       +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@h1alexbel h1alexbel merged commit c213ca5 into master Apr 1, 2024
4 of 6 checks passed
@h1alexbel h1alexbel deleted the docker.io branch April 1, 2024 08:12
@h1alexbel h1alexbel changed the title feat(#2): JsonComments, comments per review id, cov up to 0.5 feat(#2): JsonComments, comments per review id, cov up Apr 1, 2024
@h1alexbel
Copy link
Contributor Author

@rultor release, tag is 0.0.6

@rultor
Copy link
Collaborator

rultor commented Apr 1, 2024

@rultor release, tag is 0.0.6

@h1alexbel OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

rultor commented Apr 1, 2024

@rultor release, tag is 0.0.6

@h1alexbel Done! FYI, the full log is here (took me 3min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants